Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate firmware folder in smoll parent folder #22401

Merged
merged 6 commits into from
Dec 8, 2023

Conversation

SmollChungus
Copy link
Contributor

@SmollChungus SmollChungus commented Nov 4, 2023

Consolidate firmware folders into the smoll parent folder, in preparation for future additions.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 4, 2023
@dunk2k
Copy link
Contributor

dunk2k commented Nov 4, 2023

@SmollChungus
Could respective entries, for moved keyboards, be added in data/mappings/keyboard_aliases.hjson?

@SmollChungus
Copy link
Contributor Author

@SmollChungus Could respective entries, for moved keyboards, be added in data/mappings/keyboard_aliases.hjson?

Yes for sure! Is this something I would need to add to this PR / open another PR for?

@dunk2k
Copy link
Contributor

dunk2k commented Nov 4, 2023

@SmollChungus Could respective entries, for moved keyboards, be added in data/mappings/keyboard_aliases.hjson?

Yes for sure! Is this something I would need to add to this PR / open another PR for?

With this PR please 😊

@github-actions github-actions bot added the dd Data Driven Changes label Nov 4, 2023
@SmollChungus
Copy link
Contributor Author

Okay perfect, added modified mappings to the PR!

@drashna drashna requested a review from a team November 8, 2023 20:24
keyboards/smoll/lefty/rules.mk Outdated Show resolved Hide resolved
fix default folder lefty
@SmollChungus SmollChungus requested a review from zvecr November 13, 2023 08:33
@dunk2k dunk2k mentioned this pull request Nov 30, 2023
7 tasks
@zvecr zvecr merged commit 2d3f2e9 into qmk:develop Dec 8, 2023
3 checks passed
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
* consolidate firmware folder in smoll parent folder

* add moved keyboards to mapping

* typo fix

* typo..

* Update rules.mk

fix default folder lefty

* Update data/mappings/keyboard_aliases.hjson

Co-authored-by: Duncan Sutherland <[email protected]>

---------

Co-authored-by: Duncan Sutherland <[email protected]>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
* consolidate firmware folder in smoll parent folder

* add moved keyboards to mapping

* typo fix

* typo..

* Update rules.mk

fix default folder lefty

* Update data/mappings/keyboard_aliases.hjson

Co-authored-by: Duncan Sutherland <[email protected]>

---------

Co-authored-by: Duncan Sutherland <[email protected]>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
* consolidate firmware folder in smoll parent folder

* add moved keyboards to mapping

* typo fix

* typo..

* Update rules.mk

fix default folder lefty

* Update data/mappings/keyboard_aliases.hjson

Co-authored-by: Duncan Sutherland <[email protected]>

---------

Co-authored-by: Duncan Sutherland <[email protected]>
@SmollChungus SmollChungus mentioned this pull request Feb 3, 2024
7 tasks
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
* consolidate firmware folder in smoll parent folder

* add moved keyboards to mapping

* typo fix

* typo..

* Update rules.mk

fix default folder lefty

* Update data/mappings/keyboard_aliases.hjson

Co-authored-by: Duncan Sutherland <[email protected]>

---------

Co-authored-by: Duncan Sutherland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dd Data Driven Changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants