Prevent qmk migrate processing unparsed info.json values
#22374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
changed the title
qmk migrate processing unparsed info.json values
zvecr
force-pushed
the
migrate_to_json_false
branch
from
a72f429 to
5199433
Compare
zvecr
force-pushed
the
migrate_to_json_false
branch
from
5199433 to
1e74973
Compare
tzarc
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the DD mappings are set to
"to_json": false, there is no replacement data for migration. The result right now is the original is removed, with nothing added toinfo.json.This PR makes migrate ignore these problematic values for now. Ive also added some logic to reject
array.array.xtypes due to the incorrect parsing.Types of Changes
Issues Fixed or Closed by This PR
Checklist