Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMMK2 65% ISO Community Layout Support #22152

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • Refactor LAYOUT into LAYOUT_65_iso_blocker
    Move the Enter key to the end of the home row for Community Layout
    compatibility.
  • Enable Community Layout support

cc @itarze (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Move the Enter key to the end of the home row for Community Layout
compatibility.

[chore] [refactor]
@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 28, 2023
@noroadsleft noroadsleft requested a review from a team September 28, 2023 01:03
@zvecr zvecr merged commit 4a855bd into qmk:develop Sep 28, 2023
3 checks passed
@noroadsleft noroadsleft deleted the dev/gmmk_gmmk2_p65_iso branch October 5, 2023 06:49
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
* Refactor `LAYOUT` into `LAYOUT_65_iso_blocker`

Move the Enter key to the end of the home row for Community Layout
compatibility.

[chore] [refactor]

* Enable Community Layout support

[enhancement]
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
* Refactor `LAYOUT` into `LAYOUT_65_iso_blocker`

Move the Enter key to the end of the home row for Community Layout
compatibility.

[chore] [refactor]

* Enable Community Layout support

[enhancement]
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
* Refactor `LAYOUT` into `LAYOUT_65_iso_blocker`

Move the Enter key to the end of the home row for Community Layout
compatibility.

[chore] [refactor]

* Enable Community Layout support

[enhancement]
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
* Refactor `LAYOUT` into `LAYOUT_65_iso_blocker`

Move the Enter key to the end of the home row for Community Layout
compatibility.

[chore] [refactor]

* Enable Community Layout support

[enhancement]
mute-civilian pushed a commit to mute-civilian/qmk_firmware that referenced this pull request Feb 17, 2024
* Refactor `LAYOUT` into `LAYOUT_65_iso_blocker`

Move the Enter key to the end of the home row for Community Layout
compatibility.

[chore] [refactor]

* Enable Community Layout support

[enhancement]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants