Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Keychron Q3 #21995

Merged
merged 21 commits into from
Oct 4, 2023
Merged

Update Keychron Q3 #21995

merged 21 commits into from
Oct 4, 2023

Conversation

adophoxia
Copy link
Contributor

Description

Superseeds #21406, but this will only cover one board from each series update of PRs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

dunk2k
dunk2k suggested changes Sep 20, 2023
View reviewed changes
keyboards/keychron/q3/ansi_encoder/info.json Show resolved Hide resolved
keyboards/keychron/q3/ansi/info.json Show resolved Hide resolved
keyboards/keychron/q3/iso/info.json Show resolved Hide resolved
keyboards/keychron/q3/iso_encoder/info.json Show resolved Hide resolved
keyboards/keychron/q3/jis/info.json Show resolved Hide resolved
keyboards/keychron/q3/jis_encoder/info.json Show resolved Hide resolved
keyboards/keychron/q3/readme.md Outdated Show resolved Hide resolved
drashna
drashna approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though, the community layout support would be good to have, too.

adophoxia and others added 10 commits September 21, 2023 19:41
@adophoxia
Merge branch 'develop' of https://github.com/qmk/qmk_firmware into ke…
860f899 
…ychron-q3-update
@adophoxia
Merge branch 'keychron-q3-update' of https://github.com/adophoxia/qmk…
eb59b39 
…_firmware into keychron-q3-update
@adophoxia
Move eeprom config. to info.json, remove unused features, and add…
aa62ac3 
… back `dip_switch` option.
@adophoxia
Remove redundant "features" schema from <kb>/info.json.
bcb8eee
@adophoxia @dunk2k
Update keyboards/keychron/q3/ansi_encoder/info.json
fffcdb3 
Co-authored-by: Duncan Sutherland <[email protected]>
@adophoxia @dunk2k
Update keyboards/keychron/q3/ansi/info.json
aef49f5 
Co-authored-by: Duncan Sutherland <[email protected]>
@adophoxia @dunk2k
Update keyboards/keychron/q3/iso/info.json
193de41 
Co-authored-by: Duncan Sutherland <[email protected]>
@adophoxia @dunk2k
Update keyboards/keychron/q3/iso_encoder/info.json
7cbd5f3 
Co-authored-by: Duncan Sutherland <[email protected]>
@adophoxia @dunk2k
Update keyboards/keychron/q3/jis/info.json
805597a 
Co-authored-by: Duncan Sutherland <[email protected]>
@adophoxia @dunk2k
Update keyboards/keychron/q3/jis_encoder/info.json
ae058d5 
Co-authored-by: Duncan Sutherland <[email protected]>
@adophoxia adophoxia requested a review from dunk2k September 22, 2023 04:13
@drashna
Copy link
Member

drashna commented Oct 4, 2023

CI failure is due to brandonschlack keymap. Otherwise, LGTM.

@drashna drashna merged commit 6f59236 into qmk:develop Oct 4, 2023
2 of 3 checks passed
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@adophoxia @dunk2k
@drashna @mechlovin
Update Keychron Q3 (qmk#21995)
1dd42bf 
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@adophoxia @dunk2k
@drashna @christrotter
Update Keychron Q3 (qmk#21995)
5c2d71d 
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@adophoxia @dunk2k
@drashna @zgagnon
Update Keychron Q3 (qmk#21995)
3a32bf7 
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@adophoxia @dunk2k @drashna
Update Keychron Q3 (qmk#21995)
fe542cc 
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
mute-civilian pushed a commit to mute-civilian/qmk_firmware that referenced this pull request Feb 17, 2024
@adophoxia @dunk2k @drashna
Update Keychron Q3 (qmk#21995)
0679df7 
Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
@adophoxia adophoxia deleted the keychron-q3-update branch June 27, 2024 01:44
@adophoxia adophoxia mentioned this pull request Jul 18, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@dunk2k dunk2k dunk2k approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adophoxia @drashna @dunk2k