Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromatonemini info json revised to support qmk 0.22.2 #21966

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

3araht
Copy link
Contributor

@3araht 3araht commented Sep 9, 2023

Description

info.json updated.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/chromatonemini/info.json Outdated Show resolved Hide resolved
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it uses a Pro Micro. If desired, instead of setting bootloader and processor, you could set development_board.

Using development_board will also let users build this keyboard using a converter. EDIT: converters would work anyway, as we still assume a default of promicro. The suggestion is still recommended though, as it reduces configuration items and makes things somewhat easier in the future.

diff --git a/keyboards/chromatonemini/info.json b/keyboards/chromatonemini/info.json
index 0c30f63dbe..a66a7f42e5 100644
--- a/keyboards/chromatonemini/info.json
+++ b/keyboards/chromatonemini/info.json
@@ -3,11 +3,10 @@
     "manufacturer": "3araht",
     "url": "https://github.com/3araht/chromatonemini",
     "maintainer": "3araht",
-    "bootloader": "caterina",
     "build": {
         "lto": true
     },
-    "processor": "atmega32u4",
+    "development_board": "promicro",
     "features": {
         "midi": true,
         "extrakey": true,

@tzarc tzarc merged commit de8d868 into qmk:develop Sep 25, 2023
@3araht 3araht deleted the chromatonemini_info_json branch September 30, 2023 01:21
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants