Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New keyboard addition: Orthograph #21770

Merged
merged 48 commits into from
Dec 24, 2023
Merged

New keyboard addition: Orthograph #21770

merged 48 commits into from
Dec 24, 2023

Conversation

vladkvit
Copy link
Contributor

Adding a new keyboard

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

vladkvit and others added 30 commits August 15, 2023 23:15
@vladkvit
Initial commit with the file structure
49da251
@vladkvit
filling out boilerplate
b3fc142
@vladkvit
Compiles
910a05f
@vladkvit
non-working RGB LED setup
a5fa6f3
@vladkvit
LEDs for all keys working
11bae55
@vladkvit
Disabled RGB LED drivers since that's not supported for split keyboar…
a62f560 
…ds on QMK. Set up firmware to look at EEPROM for handedness;
@vladkvit
updated keymap
ae02416
@vladkvit
Modified keymap.
ec8797b
@vladkvit
Working firmware with i2c prototype
51e5e5d
@vladkvit
Got some form of RGB LED going on both splits. Currently, not all LED…
82cb5c1 
…s are being displayed, need to hunt that down. And the RGB map for the right split needs trimming (some rows are only 7 keys)
@vladkvit
LEDs mostly work now. Need to fix the two arrow keys (figure out whic…
efa0fab 
…h 2 RGB pins to comment out)
@vladkvit
Should be better but didn't change anything
43ab866
@vladkvit
Added RGB LED positions. Right side still missing some LEDs
45bc173
@vladkvit
Added some keypress RGB effects. This requires QMK changes to work (o…
7c983c8 
…ther diff)
@vladkvit
added keycomms for rgb effects
3964a86
@vladkvit
Removed some RGB effects
dd1a000
@vladkvit
Change needed to keep building on develop branch (still doesn't build…
eb5033d 
…, but gets further)
@vladkvit
Disabled some more RGB effects, and added the ones that are "allowed"…
e267448 
…. Should free up memory.
@vladkvit
Disabled another animation. Removed duplicate define.
75ec2d2
@vladkvit
Added screenshot button, reverting link time optimization
ea5b3b3
@vladkvit
Added faster USB polling and eager debouncing.
62a0346
@vladkvit
Updated debouncing for eager keydown, defer keyup to fix issues.
b25bcee
@vladkvit
Initial updates to get keyboard specs to be data driven.
c44aded
@vladkvit
Some more data driven migrations
a01d782
@vladkvit
Updated layout in info.json
43b3177
@vladkvit
Version info fix.
5a9b657
@vladkvit
Added RGB LED count; fixed vertical keyboard offset
07c49e9
@vladkvit
More minor fixes to make firmware build.
f512cb5
@vladkvit
Added key matrix positions.
1da737a
@vladkvit
RGB fix (still not fully working - right side is only using LED mappi…
1376ca4 
…ng from the left side), layout fix, include fix, other fixes.
@vladkvit
Copy link
Contributor Author

Applied suggestions from code review.

dunk2k
dunk2k suggested changes Aug 17, 2023
View reviewed changes
keyboards/orthograph/config.h Show resolved Hide resolved
keyboards/orthograph/info.json Show resolved Hide resolved
@vladkvit
Copy link
Contributor Author

Addressed comments.

@vladkvit vladkvit requested a review from zvecr August 19, 2023 16:40
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 14, 2023
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Nov 30, 2023
drashna
drashna requested changes Dec 23, 2023
View reviewed changes
keyboards/orthograph/config.h Outdated Show resolved Hide resolved
keyboards/orthograph/config.h Outdated Show resolved Hide resolved
keyboards/orthograph/info.json Outdated Show resolved Hide resolved
keyboards/orthograph/readme.md Outdated Show resolved Hide resolved
@drashna drashna merged commit 830ca0c into qmk:develop Dec 24, 2023
3 checks passed
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@vladkvit @zvecr
@waffle87 @drashna @itsjonny96
[Keyboard] Add Orthograph (qmk#21770)
81e45f1 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Vlad Kvitnevskiy <[email protected]>
Co-authored-by: Your Name <[email protected]>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@vladkvit @zvecr
@waffle87 @drashna @mechlovin
[Keyboard] Add Orthograph (qmk#21770)
e68f8b4 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Vlad Kvitnevskiy <[email protected]>
Co-authored-by: Your Name <[email protected]>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@vladkvit @zvecr
@waffle87 @drashna @mechlovin
[Keyboard] Add Orthograph (qmk#21770)
324dd2e 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Vlad Kvitnevskiy <[email protected]>
Co-authored-by: Your Name <[email protected]>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@vladkvit @zvecr
@waffle87 @drashna @nuess0r
[Keyboard] Add Orthograph (qmk#21770)
0c401c0 
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Vlad Kvitnevskiy <[email protected]>
Co-authored-by: Your Name <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vladkvit @drashna @zvecr @waffle87 @dunk2k