feat: add squigglybob splitkb kyria rev2 keymap

[squigglybob]

Description

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[dunk2k]

@squigglybob
Do you require this keymap to be exclusive to rev2?

[squigglybob]

Hi @dunk2k, yes I only have a rev 2, so it doesn't need to run on a rev3 or 1.
Is there a way to restrict it?

[dunk2k]

Hi @dunk2k, yes I only have a rev 2, so it doesn't need to run on a rev3 or 1. Is there a way to restrict it?

oh yeah! create a keymaps directory in rev2 directory, and place your keymap directory in newly created rev2/keymaps directory:
i.e. directory structure would look like this:

keyboards/
└─splitkb/
    └─kyria/
      └─rev2/
          └─keymaps/
            └─squigglybob/

[dunk2k]

For your consideration - opportunity to use encoder_map code instead of encoder code in keymap.c 🤔

[squigglybob]

For your consideration - opportunity to use encoder_map code instead of encoder code in keymap.c 🤔

I don't currently have an encoder knob on my keyboard.
Are you talking about the part after #ifdef ENCODER_ENABLE

[dunk2k]

I don't currently have an encoder knob on my keyboard. Are you talking about the part after #ifdef ENCODER_ENABLE

Correct. Based on your response, if you don't use an encoder then it may be best not to include code for one.
Add ENCODER_ENABLE = no into your keymap's rules.mk to disable encoder, in turn reducing firmware size.

[waffle87]

This also should not be in its own keymaps directory (keyboards/splitkb/kyria/rev2/keymaps/...). It needs to be moved to keyboards/splitkb/kyria/keymaps/....

[squigglybob]

This also should not be in its own keymaps directory (keyboards/splitkb/kyria/rev2/keymaps/...). It needs to be moved to keyboards/splitkb/kyria/keymaps/....

that is where I initially put the keymap, but @dunk2k suggested it go in a keymaps folder within rev2 as the keymap is specific to rev2 and was failing the build tests for rev3

[waffle87]

that is where I initially put the keymap, but @dunk2k suggested it go in a keymaps folder within rev2 as the keymap is specific to rev2 and was failing the build tests for rev3

It doesn't really matter if it fails to build for PCB versions you don't have.

[drashna]

It doesn't really matter if it fails to build for PCB versions you don't have.

I'd say that if you're okay with it in rev2/keymaps/(name), that's fine. But definitely isn't a requirement.

@waffle87 I'd say that it's okay to be in it's own folder, as there are a number of use cases that would good. But yeah, in this case, not sure it really should be but shouldn't matter either way, TBH.

[squigglybob]

It doesn't really matter if it fails to build for PCB versions you don't have.

I'd say that if you're okay with it in rev2/keymaps/(name), that's fine. But definitely isn't a requirement.

@waffle87 I'd say that it's okay to be in it's own folder, as there are a number of use cases that would good. But yeah, in this case, not sure it really should be but shouldn't matter either way, TBH.

ok, no worries, I've moved it back to kyria/keymaps anyways