[Core] Allow customizing PWM frequency #21717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some frequencies can cause audible noise. Changing the frequency eliminates that. Signed-off-by: Daniel Schaefer <[email protected]>
lesshonor
approved these changes
Aug 9, 2023
|
Nice addition! To round this out, I suggest to update the QMK documentation so that people are aware of this new option. How to do that:
|
Signed-off-by: Daniel Schaefer <[email protected]>
drashna
approved these changes
Aug 10, 2023
zvecr
reviewed
Sep 7, 2023
| @@ -73,6 +73,7 @@ To configure the backlighting, `#define` these in your `config.h`: | |||
| |`BACKLIGHT_LIMIT_VAL` |`255` |The maximum duty cycle of the backlight -- `255` allows for full brightness, any lower will decrease the maximum.| | |||
| |`BACKLIGHT_DEFAULT_LEVEL` |`BACKLIGHT_LEVELS`|The default backlight level to use upon clearing the EEPROM | | |||
| |`BACKLIGHT_DEFAULT_BREATHING`|*Not defined* |Whether to enable backlight breathing upon clearing the EEPROM | | |||
| |`BACKLIGHT_PWM_PERIOD` |2048Hz |Defaults to `BACKLIGHT_PWM_COUNTER_FREQUENCY / 2048`, which results in a PWM frequency of 2048Hz. | | |||
There was a problem hiding this comment.
Default here is incorrect for the majority of ChibiOS supported boards, and only correct for RP2040.
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Oct 25, 2023
* [Core] Allow customizing PWM frequency Some frequencies can cause audible noise. Changing the frequency eliminates that. Signed-off-by: Daniel Schaefer <[email protected]> * docs/feature-backlight: Mention PWM frequency Signed-off-by: Daniel Schaefer <[email protected]> --------- Signed-off-by: Daniel Schaefer <[email protected]>
14 tasks
zgagnon
pushed a commit
to zgagnon/qmk_firmware_waterfowl
that referenced
this pull request
Dec 15, 2023
* [Core] Allow customizing PWM frequency Some frequencies can cause audible noise. Changing the frequency eliminates that. Signed-off-by: Daniel Schaefer <[email protected]> * docs/feature-backlight: Mention PWM frequency Signed-off-by: Daniel Schaefer <[email protected]> --------- Signed-off-by: Daniel Schaefer <[email protected]>
future-figs
pushed a commit
to future-figs/qmk_firmware
that referenced
this pull request
Dec 27, 2023
* [Core] Allow customizing PWM frequency Some frequencies can cause audible noise. Changing the frequency eliminates that. Signed-off-by: Daniel Schaefer <[email protected]> * docs/feature-backlight: Mention PWM frequency Signed-off-by: Daniel Schaefer <[email protected]> --------- Signed-off-by: Daniel Schaefer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some frequencies can cause audible noise. Changing the frequency eliminates that.
Types of Changes
Checklist
Tested on Framework 16 keyboard (not upstreamed yet).