Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup STM32-DFU #21447

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Fixup STM32-DFU #21447

merged 1 commit into from
Jul 4, 2023

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jul 4, 2023 •
edited
Loading

Description

After #21352 other families weren't jumping to bootloader correctly.

Fixed version is confirmed functional on F303, H723, F072.

Unrelated verification:
G474 still functional, though it uses the different dual-bank implementation instead.
F401 with tinyuf2 still functional, too.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc added the bug label Jul 4, 2023
@tzarc tzarc requested a review from a team July 4, 2023 06:47
@github-actions github-actions bot added the core label Jul 4, 2023
drashna
drashna approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm fixes on an f303 (moonlander).

@drashna drashna requested a review from a team July 4, 2023 07:32
@tzarc tzarc merged commit 2976bd6 into qmk:develop Jul 4, 2023
@tzarc tzarc deleted the bugfix/bootloader-jump branch July 4, 2023 11:16
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@tzarc @jesperhellberg
Fixup STM32-DFU (qmk#21447)
ae0f1f0
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@tzarc @thismarvin
Fixup STM32-DFU (qmk#21447)
048c2d4
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@tzarc @akeep
Fixup STM32-DFU (qmk#21447)
4197219
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@tzarc @csolje
Fixup STM32-DFU (qmk#21447)
75d8289
jashort pushed a commit to jashort/qmk_firmware that referenced this pull request Nov 20, 2023
@tzarc @jashort
Fixup STM32-DFU (qmk#21447)
6eac4ec
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@tzarc @autoferrit
Fixup STM32-DFU (qmk#21447)
a601d5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tzarc @drashna