Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kyria: remove LAYOUT_stack #21384

Merged
merged 1 commit into from
Jul 7, 2023
Merged

kyria: remove LAYOUT_stack #21384

merged 1 commit into from
Jul 7, 2023

Conversation

fauxpark
Copy link
Member

Description

LAYOUT_stack places all of the right-hand keys "below" the left hand:
image

Whereas the more conventionally correct ordering is used by LAYOUT_split_3x6_5:
image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team June 26, 2023 01:40
@fauxpark
Copy link
Member Author

SHAs all match. uqs keymap build failure is unrelated.

@tzarc tzarc merged commit d83578d into qmk:develop Jul 7, 2023
@fauxpark fauxpark deleted the kyria-remove-stack-layout branch July 7, 2023 11:21
This was referenced Jul 17, 2023
Closed
Merged
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@fauxpark @jesperhellberg
kyria: remove LAYOUT_stack (qmk#21384)
d618f99
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@fauxpark @thismarvin
kyria: remove LAYOUT_stack (qmk#21384)
3f6c2a0
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@fauxpark @akeep
kyria: remove LAYOUT_stack (qmk#21384)
3e7da9b
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@fauxpark @csolje
kyria: remove LAYOUT_stack (qmk#21384)
19f0577
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@fauxpark @autoferrit
kyria: remove LAYOUT_stack (qmk#21384)
7904c64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @tzarc