Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow planck/rev7 to be used with ENCODER_ENABLE = no #21213

Closed

Conversation

PeterFalken
Copy link
Contributor

Description

Allows planck/rev7 to be used with ENCODER_ENABLE = no

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@PeterFalken
Copy link
Contributor Author

PeterFalken commented Jun 11, 2023

@jackhumbert, @drashna, this PR fixes a small edge case on #21175 where the planck/rev7 won't compile if ENCODER_ENABLE = no is present in rules.mk. Since both functions (encoder_exec_mapping & encoder_update_kb) share the same method signature an alias can be used as reference.

@drashna drashna requested review from jackhumbert and a team June 12, 2023 01:22
@jackhumbert jackhumbert mentioned this pull request Jun 17, 2023
14 tasks
@jackhumbert
Copy link
Member

Thanks for catching that! I merged your changes into #21196 - the encoder map unfortunately doesn't work with this setup, so the aliases aren't needed, but it should work without encoders enabled now :)

@PeterFalken PeterFalken deleted the fix-planck-rev7-disabled-encoder branch June 21, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants