Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RGBLIGHT_SPLIT to data driven #21190

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Move RGBLIGHT_SPLIT to data driven #21190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ed24ca
Move `RGBLIGHT_SPLIT` to data driven
fauxpark Jun 9, 2023
7c25abe
Remove where `split_count` is already set
fauxpark Jun 12, 2023
67eb7e8
Merge branch 'develop' into rgblight-split-data-driven
fauxpark Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion keyboards/aleblazer/zodiark/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#ifdef RGBLIGHT_ENABLE
#define RGBLED_NUM 68
#define RGBLIGHT_SPLIT
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
Expand Down
1 change: 0 additions & 1 deletion keyboards/avalanche/v2/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@
#pragma once

#define RGBLED_NUM 12
#define RGBLIGHT_SPLIT
1 change: 0 additions & 1 deletion keyboards/avalanche/v3/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@
#pragma once

#define RGBLED_NUM 12
#define RGBLIGHT_SPLIT
1 change: 0 additions & 1 deletion keyboards/avalanche/v4/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

#ifdef RGBLIGHT_ENABLE
# define RGBLED_NUM 64
# define RGBLIGHT_SPLIT
# define RGBLIGHT_HUE_STEP 10
# define RGBLIGHT_SAT_STEP 17
# define RGBLIGHT_VAL_STEP 17
Expand Down
1 change: 0 additions & 1 deletion keyboards/bastardkb/tbk/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#pragma once

#define RGBLED_NUM 38
#define RGBLIGHT_SPLIT
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
Expand Down
1 change: 0 additions & 1 deletion keyboards/bluebell/swoop/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
#define RGBLIGHT_EFFECT_STATIC_GRADIENT
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLED_NUM 36
#define RGBLIGHT_SPLIT
#define RGBLIGHT_HUE_STEP 10
#define RGBLIGHT_SAT_STEP 17
#define RGBLIGHT_VAL_STEP 17
Expand Down
1 change: 0 additions & 1 deletion keyboards/crkbd/rev1/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#ifdef RGBLIGHT_ENABLE
# define RGBLED_NUM 54 // Number of LEDs
# define RGBLIGHT_SPLIT
#endif

#ifdef RGB_MATRIX_ENABLE
Expand Down
1 change: 0 additions & 1 deletion keyboards/doppelganger/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
// #define USE_I2C

#define RGBLED_NUM 2
#define RGBLIGHT_SPLIT

/* Mechanical locking support. Use KC_LCAP, KC_LNUM or KC_LSCR instead in keymap */
#define LOCKING_SUPPORT_ENABLE
Expand Down
1 change: 0 additions & 1 deletion keyboards/draculad/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define RGBLIGHT_EFFECT_STATIC_GRADIENT
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLED_NUM 10
#define RGBLIGHT_SPLIT
#define RGBLIGHT_HUE_STEP 8
#define RGBLIGHT_SAT_STEP 8
#define RGBLIGHT_VAL_STEP 8
Expand Down
3 changes: 3 additions & 0 deletions keyboards/draculad/info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"pid": "0x1B1E",
"device_version": "0.0.1"
},
"rgblight": {
"split": true
},
"ws2812": {
"pin": "D3"
},
Expand Down
1 change: 0 additions & 1 deletion keyboards/flxlb/zplit/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

/* ws2812 RGB LED */
#define RGBLED_NUM 16
#define RGBLIGHT_SPLIT
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
Expand Down
1 change: 0 additions & 1 deletion keyboards/halfcliff/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MATRIX_COL_PINS { B4, E6, C6, B6, B2 }

#define RGBLED_NUM 10
#define RGBLIGHT_SPLIT
#define RGBLIGHT_HUE_STEP 8
#define RGBLIGHT_SAT_STEP 8
#define RGBLIGHT_VAL_STEP 8
Expand Down
2 changes: 0 additions & 2 deletions keyboards/handwired/brain/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#define RGBLED_NUM 28 // Number of LEDs

#define RGBLIGHT_SPLIT

/*
* Feature disable options
* These options are also useful to firmware size reduction.
Expand Down
1 change: 1 addition & 0 deletions keyboards/handwired/brain/info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"pin": "D3"
},
"rgblight": {
"split": true,
"max_brightness": 120
},
"split": {
Expand Down
1 change: 0 additions & 1 deletion keyboards/handwired/freoduo/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
/* ws2812 RGB LED */
#if !defined(RGBLED_NUM)
# define RGBLED_NUM 30
# define RGBLIGHT_SPLIT
# define RGBLIGHT_LAYERS
#endif
#define RGBLIGHT_EFFECT_BREATHING
Expand Down
1 change: 0 additions & 1 deletion keyboards/handwired/tractyl_manuform/5x6_right/elite_c/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

// WS2812 RGB LED strip input and number of LEDs
#define RGBLED_NUM 20
#define RGBLIGHT_SPLIT

#define AUDIO_PIN C6

Expand Down
1 change: 0 additions & 1 deletion keyboards/handwired/tractyl_manuform/5x6_right/f303/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define WS2812_DMA_CHANNEL 3 // DMA Channel for TIMx_UP, see the respective reference manual for the appropriate values for your MCU.

#define RGBLED_NUM 20
#define RGBLIGHT_SPLIT

#define DEBUG_LED_PIN C13

Expand Down
1 change: 0 additions & 1 deletion keyboards/handwired/tractyl_manuform/5x6_right/f411/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.


#define RGBLED_NUM 57
#define RGBLIGHT_SPLIT

#define DEBUG_LED_PIN C13

Expand Down
1 change: 0 additions & 1 deletion keyboards/handwired/tractyl_manuform/5x6_right/teensy2pp/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

// WS2812 RGB LED strip input and number of LEDs
#define RGBLED_NUM 20
#define RGBLIGHT_SPLIT
#define RGBLIGHT_LIMIT_VAL 80

#define DEBUG_LED_PIN D6
Expand Down
1 change: 0 additions & 1 deletion keyboards/handwired/tsubasa/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define MASTER_RIGHT

# define RGBLED_NUM 12
# define RGBLIGHT_SPLIT
# define RGBLIGHT_HUE_STEP 8
# define RGBLIGHT_SAT_STEP 1
# define RGBLIGHT_VAL_STEP 1
Expand Down
1 change: 0 additions & 1 deletion keyboards/helix/rev3_4rows/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#endif

#ifdef RGBLIGHT_ENABLE
#define RGBLIGHT_SPLIT
// #define RGBLIGHT_HUE_STEP 8
// #define RGBLIGHT_SAT_STEP 8
// #define RGBLIGHT_VAL_STEP 8
Expand Down
1 change: 0 additions & 1 deletion keyboards/helix/rev3_5rows/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#endif

#ifdef RGBLIGHT_ENABLE
#define RGBLIGHT_SPLIT
// #define RGBLIGHT_HUE_STEP 8
// #define RGBLIGHT_SAT_STEP 8
// #define RGBLIGHT_VAL_STEP 8
Expand Down
1 change: 0 additions & 1 deletion keyboards/hidtech/bastyl/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#pragma once

#define RGBLED_NUM 38
#define RGBLIGHT_SPLIT
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
Expand Down
3 changes: 3 additions & 0 deletions keyboards/hidtech/bastyl/info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
"ws2812": {
"pin": "D2"
},
"rgblight": {
"split": true
},
"processor": "atmega32u4",
"bootloader": "atmel-dfu",
"layouts": {
Expand Down
1 change: 0 additions & 1 deletion keyboards/jian/nsrev2/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define RGBLIGHT_EFFECT_TWINKLE

#define RGBLIGHT_SLEEP
#define RGBLIGHT_SPLIT

#ifndef IOS_DEVICE_ENABLE
#if RGBLED_NUM <= 6
Expand Down
3 changes: 3 additions & 0 deletions keyboards/jian/nsrev2/info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"levels": 5,
"breathing": true
},
"rgblight": {
"split": true
},
"ws2812": {
"pin": "D4"
},
Expand Down
1 change: 0 additions & 1 deletion keyboards/jian/rev1/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.


#define RGBLIGHT_SLEEP
#define RGBLIGHT_SPLIT

#ifndef IOS_DEVICE_ENABLE
#if RGBLED_NUM <= 6
Expand Down
3 changes: 3 additions & 0 deletions keyboards/jian/rev1/info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
"pin": "B6",
"levels": 5
},
"rgblight": {
"split": true
},
"ws2812": {
"pin": "D4"
},
Expand Down
1 change: 0 additions & 1 deletion keyboards/jian/rev2/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define RGBLIGHT_EFFECT_TWINKLE

#define RGBLIGHT_SLEEP
#define RGBLIGHT_SPLIT

#ifndef IOS_DEVICE_ENABLE
#if RGBLED_NUM <= 6
Expand Down
3 changes: 3 additions & 0 deletions keyboards/jian/rev2/info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
"pin": "C6",
"levels": 5
},
"rgblight": {
"split": true
},
"ws2812": {
"pin": "D4"
},
Expand Down
1 change: 0 additions & 1 deletion keyboards/jiran/rev2/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define RGBLIGHT_EFFECT_ALTERNATING
#define RGBLIGHT_EFFECT_TWINKLE
#define RGBLED_NUM 56
#define RGBLIGHT_SPLIT
#define RGBLIGHT_HUE_STEP 10
#define RGBLIGHT_SAT_STEP 17
#define RGBLIGHT_VAL_STEP 17
1 change: 0 additions & 1 deletion keyboards/kagizaraya/scythe/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.

#pragma once

#define RGBLIGHT_SPLIT 1
#define RGBLIGHT_EFFECT_BREATHING
#define RGBLIGHT_EFFECT_RAINBOW_MOOD
#define RGBLIGHT_EFFECT_RAINBOW_SWIRL
Expand Down
3 changes: 3 additions & 0 deletions keyboards/kagizaraya/scythe/info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
"split": {
"soft_serial_pin": "D0"
},
"rgblight": {
"split": true
},
"ws2812": {
"pin": "F0"
},
Expand Down
1 change: 0 additions & 1 deletion keyboards/kapl/rev1/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#define MASTER_LEFT

#define RGBLED_NUM 88
#define RGBLIGHT_SPLIT

#define RGB_MATRIX_LED_COUNT 88
#define RGB_MATRIX_SPLIT { 44, 44 }
Expand Down
1 change: 0 additions & 1 deletion keyboards/keycapsss/kimiko/rev1/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

#ifdef RGBLIGHT_ENABLE
# define RGBLED_NUM 60 // Total number of LEDs
# define RGBLIGHT_SPLIT
#endif

// Limit the power draw
Expand Down
2 changes: 0 additions & 2 deletions keyboards/lily58/glow_enc/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,3 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#pragma once

#define RGBLED_NUM 72 // Number of LEDs

#define RGBLIGHT_SPLIT
1 change: 0 additions & 1 deletion keyboards/lily58/light/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,3 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#pragma once

#define RGBLED_NUM 70
#define RGBLIGHT_SPLIT
1 change: 0 additions & 1 deletion keyboards/manta60/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define SELECT_SOFT_SERIAL_SPEED 1

# define RGBLED_NUM 68
# define RGBLIGHT_SPLIT
# define RGBLIGHT_HUE_STEP 8
# define RGBLIGHT_SAT_STEP 8
# ifndef IOS_DEVICE_ENABLE
Expand Down
1 change: 0 additions & 1 deletion keyboards/mechwild/mokulua/mirrored/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#define MASTER_LEFT
//#define MASTER_RIGHT
#define RGBLIGHT_SPLIT
#define SPLIT_LAYER_STATE_ENABLE
#define SPLIT_LED_STATE_ENABLE
#define SPLIT_MODS_ENABLE
Expand Down
1 change: 0 additions & 1 deletion keyboards/mechwild/mokulua/standard/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#define MASTER_LEFT
//#define MASTER_RIGHT
#define RGBLIGHT_SPLIT
#define SPLIT_LAYER_STATE_ENABLE
#define SPLIT_LED_STATE_ENABLE
#define SPLIT_MODS_ENABLE
Expand Down
1 change: 0 additions & 1 deletion keyboards/merge/um70/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#define MASTER_LEFT
#define SPLIT_MODS_ENABLE

#define RGBLIGHT_SPLIT
#define RGBLED_NUM 83
#ifdef RGB_MATRIX_ENABLE
# define RGB_MATRIX_LED_COUNT RGBLED_NUM
Expand Down
1 change: 0 additions & 1 deletion keyboards/merge/um80/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#define MASTER_LEFT
#define SPLIT_MODS_ENABLE

#define RGBLIGHT_SPLIT
#define RGBLED_NUM 100
#ifdef RGB_MATRIX_ENABLE
# define RGB_MATRIX_LED_COUNT RGBLED_NUM
Expand Down
1 change: 0 additions & 1 deletion keyboards/meson/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define USE_I2C

#define RGBLED_NUM 10
#define RGBLIGHT_SPLIT
#define RGBLIGHT_HUE_STEP 8
#define RGBLIGHT_SAT_STEP 8
#define RGBLIGHT_VAL_STEP 8
Expand Down
1 change: 0 additions & 1 deletion keyboards/mint60/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define LOCKING_RESYNC_ENABLE

#define RGBLED_NUM 8
#define RGBLIGHT_SPLIT

#define RGBLIGHT_HUE_STEP 10
#define RGBLIGHT_SAT_STEP 17
Expand Down
3 changes: 3 additions & 0 deletions keyboards/mint60/info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
"split": {
"soft_serial_pin": "D2"
},
"rgblight": {
"split": true
},
"ws2812": {
"pin": "D3"
},
Expand Down
1 change: 0 additions & 1 deletion keyboards/mlego/m60_split/rev1/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#define SERIAL_USART_SPEED 921600

#ifdef RGBLIGHT_ENABLE
#define RGBLIGHT_SPLIT
#define RGBLIGHT_LAYERS

#define RGBLIGHT_DEFAULT_HUE 213
Expand Down
1 change: 0 additions & 1 deletion keyboards/mlego/m60_split/rev2/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@


#ifdef RGBLIGHT_ENABLE
#define RGBLIGHT_SPLIT
#define RGBLIGHT_LAYERS
#define RGBLED_NUM 16
#define RGBLIGHT_EFFECT_BREATHING
Expand Down
1 change: 0 additions & 1 deletion keyboards/omkbd/ergodash/mini/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define RGBLIGHT_EFFECT_ALTERNATING
#define RGBLIGHT_EFFECT_TWINKLE
#define RGBLED_NUM 20
#define RGBLIGHT_SPLIT

#define SELECT_SOFT_SERIAL_SPEED 1
/*Sets the protocol speed when using serial communication*/
Expand Down
1 change: 0 additions & 1 deletion keyboards/omkbd/ergodash/rev1/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
#define RGBLIGHT_EFFECT_ALTERNATING
#define RGBLIGHT_EFFECT_TWINKLE
#define RGBLED_NUM 24
#define RGBLIGHT_SPLIT

#define SELECT_SOFT_SERIAL_SPEED 1
/*Sets the protocol speed when using serial communication*/
Expand Down
Loading