Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Break QGFImageFile's _save function into smaller pieces #21124

Merged
merged 8 commits into from
Feb 16, 2024

Conversation

elpekenin
Copy link
Contributor

@elpekenin elpekenin commented Jun 3, 2023

Description

Makes it somewhat easier to read and should prevent errors like the one on CI for #20101

Tested converting a GIF with and without the changes, and diff didnt find any changes

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Jun 3, 2023
bbox[2] -= 1
bbox[3] -= 1

return {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could return a tuple here (return bbox, graphic_data, image_data, use_delta_this_frame, use_raw_this_frame) But i dont like it because (1) is a very long line (2) prone to errors if we re-order (read: add new) things

@elpekenin elpekenin marked this pull request as ready for review June 3, 2023 18:08
@tzarc tzarc requested a review from a team September 19, 2023 23:51
Copy link

github-actions bot commented Nov 4, 2023

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 4, 2023
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Nov 5, 2023
@zvecr zvecr merged commit cf162f9 into qmk:develop Feb 16, 2024
5 checks passed
@elpekenin elpekenin deleted the qp_cli_reduce_complexity branch February 16, 2024 13:43
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants