-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Break QGFImageFile
's _save
function into smaller pieces
#21124
Conversation
bbox[2] -= 1 | ||
bbox[3] -= 1 | ||
|
||
return { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could return a tuple here (return bbox, graphic_data, image_data, use_delta_this_frame, use_raw_this_frame
) But i dont like it because (1) is a very long line (2) prone to errors if we re-order (read: add new) things
Thank you for your contribution! |
Description
Makes it somewhat easier to read and should prevent errors like the one on CI for #20101
Tested converting a GIF with and without the changes, and
diff
didnt find any changesTypes of Changes
Issues Fixed or Closed by This PR
Checklist