Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add iNETT Studio SQUARE 80% #21082

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[Keyboard] Add iNETT Studio SQUARE 80% #21082

merged 1 commit into from
Feb 19, 2024

Conversation

Wraul
Copy link
Contributor

@Wraul Wraul commented May 29, 2023

This keyboard comes stock with a forked version of QMK that is quite outdated at this point.

I decided to go with the name sq80 to stay in line with the existing sqx, and "SQ80" has been used in some of the communication from the creators.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 29, 2023
@Wraul
Copy link
Contributor Author

Wraul commented May 29, 2023

Hmm, is the lint error an issue?
It says that there doesn't exist a community layout tkl_ansi_wkl, but I think it is in use by a couple of other keyboards?

@zvecr
Copy link
Member

zvecr commented May 29, 2023

It doesn't exist under layouts/default/ so no it does not exist. It also cannot be used by existing boards as it would produce lint errors, which there are none in that area.

@Wraul
Copy link
Contributor Author

Wraul commented May 29, 2023

I see.
I have removed it from the community_layouts array for now.

dunk2k
dunk2k suggested changes Aug 17, 2023
View reviewed changes
keyboards/inett_studio/sq80/info.json Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team August 26, 2023 01:05
fauxpark
fauxpark requested changes Aug 26, 2023
View reviewed changes
keyboards/inett_studio/sq80/rules.mk Outdated Show resolved Hide resolved
dunk2k
dunk2k suggested changes Aug 26, 2023
View reviewed changes
keyboards/inett_studio/sq80/info.json Outdated Show resolved Hide resolved
keyboards/inett_studio/sq80/info.json Outdated Show resolved Hide resolved
Wraul
Wraul commented Aug 26, 2023
View reviewed changes
keyboards/inett_studio/sq80/info.json Outdated
{ "matrix": [5, 14], "x": 17.25, "y": 5.5 }
]
},
"LAYOUT_tkl_ansi_wkl": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I'm confused again.
Isn't this a textbook example of a WKL layout?

If we were to assume that I interpreted your other comment correct and that in QMK tsangan only refers to the bottom row. Then tsangan_wkl doesn't make sense, as it would be identical to wkl. Which is exactly what you are saying. But surely we should prefer the most fundamental layout and use wkl when referring to this layout?

If you really want me to, I will make the requested changes. But I can't help to feel like something isn't 100% right here.

noroadsleft
noroadsleft requested changes Oct 8, 2023
View reviewed changes
keyboards/inett_studio/sq80/info.json Outdated Show resolved Hide resolved
@noroadsleft
Copy link
Member

I'm sorry, I'm confused again.
Isn't this a textbook example of a WKL layout?

@Wraul,

Your LAYOUT_tkl_ansi_wkl implementation is 100% fine as to the intended upcoming Community Layout implementation in my opinion, and other usages in the repository. 👍

As an aside, this may need a mild rename to disambiguate which PCBs are supported, because it's not 100% clear to me. The readme.md says this supports The QMK compatible hot swappable PCB offered during the GB, but according to the thread, there are at least two QMK-compatible hotswap PCBs:

image

@Wraul
Copy link
Contributor Author

Wraul commented Oct 14, 2023

@noroadsleft

As an aside, this may need a mild rename to disambiguate which PCBs are supported, because it's not 100% clear to me. The readme.md says this supports The QMK compatible hot swappable PCB offered during the GB, but according to the thread, there are at least two QMK-compatible hotswap PCBs:

image

Honestly I'm not really sure which PCBs are compatible. I only have one of the hotswap WK ones.

Though my assumption is that all of the QMK compatible PCBs are essentially the same from a matrix perspective. But due to the limitations with the hotswap sockets they can only support one layout at a time. Hence the different versions.

But I have not real evidence to support this assumption.

dunk2k
dunk2k suggested changes Nov 24, 2023
View reviewed changes
keyboards/inett_studio/sq80/info.json Outdated Show resolved Hide resolved
dunk2k
dunk2k suggested changes Nov 24, 2023
View reviewed changes
keyboards/inett_studio/sq80/info.json Outdated
{ "matrix": [5, 4], "w": 1.5, "x": 0, "y": 5.5 },
{ "matrix": [5, 6], "w": 1.5, "x": 2.5, "y": 5.5 },
{ "matrix": [5, 7], "w": 7, "x": 4, "y": 5.5 },
{ "matrix": [5, 8], "w": 1.5, "x": 11, "y": 5.5 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick check: Is matrix co-ordinate for this key (1.5u key right side of 7u spacebar) [5, 8] or [5, 9]?

@Wraul Wraul force-pushed the add-sq80 branch 4 times, most recently from 842c49d to c23b7fd Compare December 3, 2023 09:23
@Wraul
Copy link
Contributor Author

Wraul commented Dec 3, 2023

@dunk2k

I have spent some time looking into this a bit further, including digging out my SQ80 and looking at the PCB.

The PCB I have is the "QMK WK Layout I" and it only has traces for that exact layout. This would indicate that each of the different layouts has unique PCBs. Which to be honest is exactly what the GB thread states.

I have updated the PR to reflect this by adding it as a PCB subdir/revision.
I have also removed any other PCB layouts besides the one that I have, as I have no way of knowing their matrices.

@dunk2k
Copy link
Contributor

dunk2k commented Dec 3, 2023

@dunk2k

I have spent some time looking into this a bit further, including digging out my SQ80 and looking at the PCB.

The PCB I have is the "QMK WK Layout I" and it only has traces for that exact layout. This would indicate that each of the different layouts has unique PCBs. Which to be honest is exactly what the GB thread states.

I have updated the PR to reflect this by adding it as a PCB subdir/revision. I have also removed any other PCB layouts besides the one that I have, as I have no way of knowing their matrices.

@Wraul
Great work, thank you 🙂

@drashna drashna requested a review from a team December 9, 2023 06:04
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 24, 2024
@Wraul
[Keyboard] Add iNETT Studio SQUARE 80%
746185b 
This keyboard comes stock with a forked version of QMK that is quite
outdated at this point.

I decided to go with the name `sq80` to stay in line with the existing
`sqx`, and "SQ80" has been used in some of the communication from the
creators.
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Feb 19, 2024
@waffle87 waffle87 merged commit 958ddea into qmk:master Feb 19, 2024
3 checks passed
peepeetee pushed a commit to peepeetee/qmk_firmware that referenced this pull request Mar 12, 2024
@Wraul @peepeetee
[Keyboard] Add iNETT Studio SQUARE 80% (qmk#21082)
b7a98b1 
This keyboard comes stock with a forked version of QMK that is quite
outdated at this point.

I decided to go with the name `sq80` to stay in line with the existing
`sqx`, and "SQ80" has been used in some of the communication from the
creators.
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@Wraul @nuess0r
[Keyboard] Add iNETT Studio SQUARE 80% (qmk#21082)
b227d1d 
This keyboard comes stock with a forked version of QMK that is quite
outdated at this point.

I decided to go with the name `sq80` to stay in line with the existing
`sqx`, and "SQ80" has been used in some of the communication from the
creators.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft requested changes

@dunk2k dunk2k dunk2k requested changes

@fauxpark fauxpark fauxpark requested changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Wraul @zvecr @noroadsleft @dunk2k @drashna @fauxpark @waffle87