Move pre_process_record_kb() before process_combo()
#20969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The combo code buffers events that might be a part of some combo, and also generates virtual events for matched combos; if process_combo() is called first, pre_process_record_kb() would miss those buffered events (including the events which did not match any combo in the end), and also won't receive any events generated by combos. Calling pre_process_record_kb() before the combo code result in a much more logical behavior (pre_process_record_kb() receives all events for raw key or encoder actions before any other processing, including combos).
drashna
approved these changes
May 16, 2023
filterpaper
approved these changes
May 17, 2023
14 tasks
tzarc
approved these changes
May 20, 2023
coquizen
pushed a commit
to coquizen/qmk_firmware
that referenced
this pull request
Jun 22, 2023
autoferrit
pushed a commit
to SpaceRockMedia/bastardkb-qmk
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix up #20584 to call
pre_process_record_kb()(and thereforepre_process_record_user()) beforeprocess_combo().Adding the
pre_process_record_kb()call afterprocess_combo()is problematic —pre_process_record_kb()will miss any events which might be a part of some combo: #20584 (comment). Callingpre_process_record_kb()before the combo code would result in a much more logical behavior (pre_process_record_kb()receives all events for raw key or encoder actions before any other processing, including combos).If we ever need a callback that runs after the combo processing, but before the tapping code, it would need to be called in more places (e.g., in two places where the combo code currently calls
action_tapping_process()); but that probably could wait until some real user of such callback appears.Types of Changes
Checklist