Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AEBoards Aegis Layout Additions #20960

Merged
merged 5 commits into from
May 17, 2023
Merged

AEBoards Aegis Layout Additions #20960

merged 5 commits into from
May 17, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • rename LAYOUT_aegis to LAYOUT_all
  • add LAYOUT_numpad with reference keymap
    image
  • add LAYOUT_2u_bs_275u_rshift with reference keymap
    image

cc @Xelus22 (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

⚠ aeboards/aegis: Layout "LAYOUT_aegis" should not contain name of keyboard.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 15, 2023
@noroadsleft noroadsleft requested a review from a team May 15, 2023 08:55
@noroadsleft noroadsleft merged commit ff22015 into qmk:develop May 17, 2023
@noroadsleft noroadsleft deleted the kb_layouts/aeboards_aegis branch May 17, 2023 19:01
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
AEBoards Aegis Layout Additions (qmk#20960)
ef53c36 
* add matrix_diagram.md

* rename LAYOUT_aegis to LAYOUT_all

* info.json: apply friendly formatting

* add LAYOUT_numpad with reference keymap

* add LAYOUT_2u_bs_275u_rshift with reference keymap
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
AEBoards Aegis Layout Additions (qmk#20960)
5b289d1 
* add matrix_diagram.md

* rename LAYOUT_aegis to LAYOUT_all

* info.json: apply friendly formatting

* add LAYOUT_numpad with reference keymap

* add LAYOUT_2u_bs_275u_rshift with reference keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @drashna @fauxpark