Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RART80 Hotswap Layout Additions #20791

Merged
merged 17 commits into from
May 9, 2023
Merged

RART80 Hotswap Layout Additions #20791

merged 17 commits into from
May 9, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • add twelve layout macros
  • add a missing position to LAYOUT_all (breaks compatibility with out-of-tree keymaps)
  • enable Community Layout support
  • add layout/matrix diagram

cc @alabahuy (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft added 17 commits May 8, 2023 03:05
@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 8, 2023
@noroadsleft noroadsleft requested a review from a team May 8, 2023 10:28
@noroadsleft noroadsleft merged commit adbf635 into qmk:develop May 9, 2023
@noroadsleft noroadsleft deleted the kb_layouts/rart_rart80 branch May 9, 2023 02:47
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
RART80 Hotswap Layout Additions (qmk#20791)
9811244 
* add matrix_diagram.md

* info.json: apply friendly formatting

* refactor keymaps

- use four-space indent
- update grid alignment of keycodes

* add matrix position [4, 1] to LAYOUT_all

* add LAYOUT_tkl_f13_ansi_tsangan_split_bs_rshift

* add LAYOUT_tkl_f13_ansi_tsangan

* add LAYOUT_tkl_f13_ansi_wkl_split_bs_rshift

* add LAYOUT_tkl_f13_ansi_wkl

* add LAYOUT_tkl_f13_ansi_cwkl_split_bs_rshift

* add LAYOUT_tkl_f13_ansi_cwkl

* add LAYOUT_tkl_ansi_tsangan

* add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

* add LAYOUT_tkl_ansi_wkl

* add LAYOUT_tkl_ansi_wkl_split_bs_rshift

* add LAYOUT_tkl_ansi_cwkl

* add LAYOUT_tkl_ansi_cwkl_split_bs_rshift

* enable Community Layout support
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
RART80 Hotswap Layout Additions (qmk#20791)
a5d3361 
* add matrix_diagram.md

* info.json: apply friendly formatting

* refactor keymaps

- use four-space indent
- update grid alignment of keycodes

* add matrix position [4, 1] to LAYOUT_all

* add LAYOUT_tkl_f13_ansi_tsangan_split_bs_rshift

* add LAYOUT_tkl_f13_ansi_tsangan

* add LAYOUT_tkl_f13_ansi_wkl_split_bs_rshift

* add LAYOUT_tkl_f13_ansi_wkl

* add LAYOUT_tkl_f13_ansi_cwkl_split_bs_rshift

* add LAYOUT_tkl_f13_ansi_cwkl

* add LAYOUT_tkl_ansi_tsangan

* add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

* add LAYOUT_tkl_ansi_wkl

* add LAYOUT_tkl_ansi_wkl_split_bs_rshift

* add LAYOUT_tkl_ansi_cwkl

* add LAYOUT_tkl_ansi_cwkl_split_bs_rshift

* enable Community Layout support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @fauxpark