-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QP] Native palette support for fonts #20645
Conversation
7eacaf8
to
19b8c60
Compare
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Yes, can create a font image however you like, that's why it's a 2-stage process. See https://cdn.discordapp.com/attachments/587004793004884086/1102385305656492133/font.mp4 Adapted from: https://github.com/ianhan/BitmapFonts/blob/main/32X32-FA.png |
Yeah, bad wording... What i was actually wondering is whether the |
Thank you for your contribution! |
For what is worth.. i've been running this for a couple months and i didnt notice any issues drawing either images(non-native ones) or fonts(both native and not). Will try and use a native image tomorrow for the sake of completeness and report back (if i dont forget to test) |
Just confirmed native image too. Replaced an image from |
Co-authored-by: Joel Challis <[email protected]>
Description
PR for native colors on assets didn't update the code for rendering texts, only images, causing some lock ups. To prevent code duplication (and similar issues in the future) i've moved the code into a new function which wraps the two appenders(pixel and byte variants).
I don't like the chosen name very much, im open to suggestions
PS: Can fonts be coloured anyway?
Types of Changes
Issues Fixed or Closed by This PR
-f rgb565
(i.e. native format) #20632Checklist