Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fox Lab Time80 Layout Macro Additions #20636

Merged
merged 12 commits into from
Apr 30, 2023
Merged

Fox Lab Time80 Layout Macro Additions #20636

merged 12 commits into from
Apr 30, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • add eight new layout macros
  • enable Community Layout support
  • add layout/matrix diagram

cc @lukelex (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team April 30, 2023 05:02
fauxpark
fauxpark requested changes Apr 30, 2023
View reviewed changes
keyboards/foxlab/time80/info.json Outdated Show resolved Hide resolved
keyboards/foxlab/time80/info.json Outdated Show resolved Hide resolved
keyboards/foxlab/time80/info.json Outdated Show resolved Hide resolved
keyboards/foxlab/time80/info.json Outdated Show resolved Hide resolved
keyboards/foxlab/time80/info.json Outdated Show resolved Hide resolved
keyboards/foxlab/time80/info.json Outdated Show resolved Hide resolved
keyboards/foxlab/time80/info.json Outdated Show resolved Hide resolved
keyboards/foxlab/time80/info.json Outdated Show resolved Hide resolved
@noroadsleft noroadsleft merged commit 6c38fbb into qmk:develop Apr 30, 2023
@noroadsleft noroadsleft deleted the kb_layouts/foxlab_time80 branch April 30, 2023 08:26
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
Fox Lab Time80 Layout Macro Additions (qmk#20636)
e056dc1 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_tkl_ansi_split_bs_rshift

* add LAYOUT_tkl_ansi

* add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

* add LAYOUT_tkl_ansi_tsangan

* add LAYOUT_tkl_iso_split_bs_rshift

* add LAYOUT_tkl_iso

* add LAYOUT_tkl_iso_tsangan_split_bs_rshift

* add LAYOUT_tkl_iso_tsangan

* enable Community Layout support

* Apply suggestions from code review
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
Fox Lab Time80 Layout Macro Additions (qmk#20636)
573b724 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_tkl_ansi_split_bs_rshift

* add LAYOUT_tkl_ansi

* add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

* add LAYOUT_tkl_ansi_tsangan

* add LAYOUT_tkl_iso_split_bs_rshift

* add LAYOUT_tkl_iso

* add LAYOUT_tkl_iso_tsangan_split_bs_rshift

* add LAYOUT_tkl_iso_tsangan

* enable Community Layout support

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @fauxpark