Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FJLabs Avalon Layout Additions and Touch-Up #20620

Merged
merged 15 commits into from
Apr 30, 2023
Merged

FJLabs Avalon Layout Additions and Touch-Up #20620

merged 15 commits into from
Apr 30, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • add eight new layout macros and reference keymaps
  • add layout/matrix diagram

cc @mrnoisytiger (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 29, 2023
@noroadsleft noroadsleft requested a review from a team April 30, 2023 04:24
@noroadsleft noroadsleft merged commit 1de0115 into qmk:develop Apr 30, 2023
@noroadsleft noroadsleft deleted the kb_layouts/fjlabs_avalon branch April 30, 2023 05:52
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
FJLabs Avalon Layout Additions and Touch-Up (qmk#20620)
3c97ee5 
* add matrix_diagram.md

* info.json: correct key sequence

Fixes an off-by-one error between Right Split Backspace and Enter.

* refactor and unify keymaps

Edit the `default` and `via` keymaps for consistency layer-to-layer, to each other, and to the `info.json` layout data.

* info.json: apply friendly formatting

* add LAYOUT_ansi_blocker_split_bs

* add LAYOUT_ansi_blocker

* add LAYOUT_ansi_blocker_tsangan_split_bs

* add LAYOUT_ansi_blocker_tsangan

* add LAYOUT_iso_blocker_split_bs

* add LAYOUT_iso_blocker

* add LAYOUT_iso_blocker_tsangan_split_bs

* add LAYOUT_iso_blocker_tsangan

* add layout reference keymaps

* info.json: remove extra line breaks

* edit maintainer value
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
FJLabs Avalon Layout Additions and Touch-Up (qmk#20620)
d79f4fe 
* add matrix_diagram.md

* info.json: correct key sequence

Fixes an off-by-one error between Right Split Backspace and Enter.

* refactor and unify keymaps

Edit the `default` and `via` keymaps for consistency layer-to-layer, to each other, and to the `info.json` layout data.

* info.json: apply friendly formatting

* add LAYOUT_ansi_blocker_split_bs

* add LAYOUT_ansi_blocker

* add LAYOUT_ansi_blocker_tsangan_split_bs

* add LAYOUT_ansi_blocker_tsangan

* add LAYOUT_iso_blocker_split_bs

* add LAYOUT_iso_blocker

* add LAYOUT_iso_blocker_tsangan_split_bs

* add LAYOUT_iso_blocker_tsangan

* add layout reference keymaps

* info.json: remove extra line breaks

* edit maintainer value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @fauxpark