Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emery65 Layout Macro Additions #20613

Merged
merged 8 commits into from
Apr 29, 2023
Merged

Emery65 Layout Macro Additions #20613

merged 8 commits into from
Apr 29, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • adds three new layout macros
  • renames LAYOUT_all to LAYOUT_65_ansi_blocker_split_bs
  • enables Community Layout support
  • adds layout/matrix diagram

cc @yiancar (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 28, 2023
@noroadsleft noroadsleft requested a review from a team April 28, 2023 16:46
fauxpark
fauxpark requested changes Apr 28, 2023
View reviewed changes
keyboards/emery65/info.json Outdated Show resolved Hide resolved
keyboards/emery65/info.json Outdated Show resolved Hide resolved
keyboards/emery65/info.json Outdated Show resolved Hide resolved
@noroadsleft noroadsleft merged commit 82a7256 into qmk:develop Apr 29, 2023
@noroadsleft noroadsleft deleted the kb_layouts/emery65 branch April 29, 2023 06:48
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
Emery65 Layout Macro Additions (qmk#20613)
00213b1 
* add matrix_diagram.md

* info.json: apply friendly formatting

* rename LAYOUT_all to LAYOUT_65_ansi_blocker_split_bs

* add LAYOUT_65_ansi_blocker

* add LAYOUT_65_ansi_blocker_tsangan

* add LAYOUT_65_ansi_blocker_tsangan_split_bs

* enable Community Layout support

* Apply suggestions from code review
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
Emery65 Layout Macro Additions (qmk#20613)
d40ba90 
* add matrix_diagram.md

* info.json: apply friendly formatting

* rename LAYOUT_all to LAYOUT_65_ansi_blocker_split_bs

* add LAYOUT_65_ansi_blocker

* add LAYOUT_65_ansi_blocker_tsangan

* add LAYOUT_65_ansi_blocker_tsangan_split_bs

* enable Community Layout support

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @fauxpark