Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyboard]move kb83 keyoard #20603

Closed
wants to merge 9 commits into from
Closed

Conversation

jonylee1986
Copy link
Contributor

Description

Move hfdkb/keyboard_sw/k83 to inland/kb83

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 28, 2023
@drashna drashna requested a review from a team April 28, 2023 05:50
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in #20589:

  • data/mappings/keyboard_aliases.hjson must be updated to reflect the move, so users with pre-created configurator keymap.json files continue to detect the correct keyboard

Also, if you look at the Files changed tab in this PR, there are no changes made to hfdkb/keyboard_sw/k83. These files should be moved or removed.

This problem is likely because you re-used the original branch from #19896 instead of creating a new branch, and that branch is too different from QMK now.

@jonylee1986 jonylee1986 closed this May 4, 2023
@jonylee1986 jonylee1986 reopened this May 4, 2023
@jonylee1986 jonylee1986 closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants