Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CannonKeys Moment Hotswap Touch-Up #20565

Merged
merged 4 commits into from
Apr 26, 2023
Merged

CannonKeys Moment Hotswap Touch-Up #20565

merged 4 commits into from
Apr 26, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • renames LAYOUT_all to LAYOUT_60_tsangan_hhkb
  • refactor and touch-up default and via keymaps
  • enable Community Layout support

cc @awkannan (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
rename LAYOUT_all to LAYOUT_60_tsangan_hhkb
add0038
@noroadsleft
refactor keymaps
7e39cc6 
- use four-space indent
- grid-align keycodes
@noroadsleft
copy via keymap to default
d34b73f 
The default keymap had some keycodes that aren't appropriate for this board, and the function layer was wonky.
@noroadsleft
enable Community Layout support
16f31c6
@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 25, 2023
@noroadsleft noroadsleft requested a review from a team April 25, 2023 19:50
@drashna drashna requested a review from a team April 26, 2023 01:29
@noroadsleft noroadsleft merged commit 63ce1e2 into qmk:develop Apr 26, 2023
@noroadsleft noroadsleft deleted the kb_layouts/cannonkeys_moment_hs branch April 26, 2023 19:14
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
CannonKeys Moment Hotswap Touch-Up (qmk#20565)
866649f 
* rename LAYOUT_all to LAYOUT_60_tsangan_hhkb

* refactor keymaps

- use four-space indent
- grid-align keycodes

* copy via keymap to default

The default keymap had some keycodes that aren't appropriate for this board, and the function layer was wonky.

* enable Community Layout support
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
CannonKeys Moment Hotswap Touch-Up (qmk#20565)
5bfd657 
* rename LAYOUT_all to LAYOUT_60_tsangan_hhkb

* refactor keymaps

- use four-space indent
- grid-align keycodes

* copy via keymap to default

The default keymap had some keycodes that aren't appropriate for this board, and the function layer was wonky.

* enable Community Layout support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @drashna