Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CannonKeys Gentoo Hotswap Touch-Up #20562

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • renames LAYOUT_default to LAYOUT_65_ansi_rwkl
  • refactors default and via keymaps
  • adds layout/matrix diagram

cc @awkannan (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 25, 2023
@noroadsleft noroadsleft requested a review from a team April 25, 2023 19:06
@drashna drashna requested a review from a team April 26, 2023 01:27
@noroadsleft noroadsleft merged commit a11d8f6 into qmk:develop Apr 26, 2023
@noroadsleft noroadsleft deleted the kb_layouts/cannonkeys_gentoo_hs branch April 26, 2023 17:57
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
* add matrix_diagram.md

* info.json: apply friendly formatting

* rename LAYOUT_default to LAYOUT_65_ansi_rwkl

* refactor default and via keymaps

- use four-space indent
- grid-align keycodes

* remove RGB keycodes from via keymap

RGB lighting isn't supported.
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
* add matrix_diagram.md

* info.json: apply friendly formatting

* rename LAYOUT_default to LAYOUT_65_ansi_rwkl

* refactor default and via keymaps

- use four-space indent
- grid-align keycodes

* remove RGB keycodes from via keymap

RGB lighting isn't supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants