Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Koolertron AMAG23 Touch-Up #20496

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Koolertron AMAG23 Touch-Up #20496

merged 3 commits into from
Apr 18, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • updates relevant product links (fixes the 404 errors I was getting while researching this board)
  • renames LAYOUT_all to LAYOUT (only one layout is supported)

cc @ianmclinden (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 18, 2023
@noroadsleft noroadsleft requested a review from a team April 18, 2023 19:18
@noroadsleft noroadsleft merged commit fa10d5f into qmk:develop Apr 18, 2023
@noroadsleft noroadsleft deleted the kb_layouts/amag23 branch April 18, 2023 21:12
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
Koolertron AMAG23 Touch-Up (qmk#20496)
305454a 
* Update Product Links for AMAG23

* info.json: apply friendly formatting

* rename LAYOUT_all to LAYOUT
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
Koolertron AMAG23 Touch-Up (qmk#20496)
d62804a 
* Update Product Links for AMAG23

* info.json: apply friendly formatting

* rename LAYOUT_all to LAYOUT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @fauxpark