Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume keys correction #20476

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Volume keys correction #20476

merged 1 commit into from
Apr 17, 2023

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Apr 17, 2023

Description

  • Swap volume key positions
  • Layout alignment fix

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Apr 17, 2023
@zvecr zvecr merged commit e0a09ff into qmk:master Apr 17, 2023
@filterpaper filterpaper deleted the gmmk2-keymap-fix branch April 17, 2023 12:12
rodrigob pushed a commit to rodrigob/qmk_firmware that referenced this pull request Apr 18, 2023
quangd42 pushed a commit to quangd42/qmk_firmware that referenced this pull request Apr 20, 2023
queyenth pushed a commit to queyenth/qmk_firmware that referenced this pull request Apr 21, 2023
stratosgear pushed a commit to stratosgear/qmk_firmware that referenced this pull request Apr 26, 2023
struckmb pushed a commit to struckmb/qmk_firmware that referenced this pull request May 1, 2023
SjB added a commit to SjB/qmk_firmware that referenced this pull request May 12, 2023
* master:
  NK Plus (qmk#20392)
  [Docs] Fix suggested code pattern when a specific mod-mask is required. (qmk#20512)
  [Docs] Remove combo count from array (qmk#20511)
  Add QuadrumLabs Delta (qmk#20409)
  Adds Docs option for ArduinoIDE's example `ArduinoISP` (qmk#20486)
  GMMK 2 volume up/down Fn keys are backwards in default mapping (qmk#20476)
  Fix typo in `feature_wpm.md` title (qmk#20464)
  [Keyboard] Add Kalakos Bahrnob65 (qmk#20424)
  Tidy up stray RGB_DISABLE_TIMEOUT references (qmk#20460)
  [Keyboard] Add zoom75 wired (qmk#20396)
  [Keyboard] Add dymium65 (qmk#20257)
  Lotus58 glow (qmk#20386)
  ADPenrose Obi Layout Macro Conversion and Addition (qmk#20445)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Glorious GMMK 2 volume up/down Fn keys are backwards in default mapping
3 participants