quantum/action_util.c: Use uint8_t for oneshot_layer_data #20421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all bits are used for data encoding, this must not be signed. int8_t also breaks get_oneshot_layer(), because bit shifting on signed integers is implementation defined, so right-shift is filled up with 1s. closes: qmk#20418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since all bits of oneshot_layer_data are used for data encoding, the variable must not be signed. int8_t also breaks get_oneshot_layer() on newlib, because bit shifting on signed integers is implementation defined, so right-shift is filled up with 1s. The only reason this might work elsewhere are implementations filling up with 0.
Types of Changes
Variable type change.
Issues Fixed or Closed by This PR
Checklist