Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup RGB Pin Definitions #20359

Closed
wants to merge 1 commit into from
Closed

Fixup RGB Pin Definitions #20359

wants to merge 1 commit into from

Conversation

waffle87
Copy link
Member

@waffle87 waffle87 commented Apr 7, 2023

Description

Title.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87 waffle87 requested a review from a team April 7, 2023 16:41
@fauxpark
Copy link
Member

fauxpark commented Apr 7, 2023

Already done in #20350

@waffle87
Copy link
Member Author

waffle87 commented Apr 7, 2023

Ah cheers

@waffle87 waffle87 closed this Apr 7, 2023
@waffle87 waffle87 deleted the fix/ws2812_pin branch April 8, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @fauxpark @zvecr