Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandominedoni samenotefix with info.json modifications #20358

Closed

Conversation

3araht
Copy link
Contributor

@3araht 3araht commented Apr 7, 2023

Description

An issue with multiple same notes played at the same time is fixed.
(Modifications in #20352 applied to the develop branch in order to avoid conflicts in info.json.)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

tzarc and others added 30 commits February 28, 2023 11:30
* added soft reset and auto lowpower for AW20216
fauxpark and others added 21 commits April 5, 2023 15:46
…mk#20347)

* Remove stray defines and per key functions

* Remove defunct get_ignore_mod_tap_interrupt declaration
@github-actions github-actions bot added CI core documentation keyboard keymap translation via Adds via keymap and/or updates keyboard for via support labels Apr 7, 2023
@3araht 3araht closed this Apr 7, 2023
@3araht
Copy link
Contributor Author

3araht commented Apr 7, 2023

I made a mistake. I should have made a pull request to a develop branch instead of a master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI core documentation keyboard keymap translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.