Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jacky_studio/piggy60] move AVR PCB under rev1 #20253

Merged
merged 2 commits into from
Mar 29, 2023
Merged

[jacky_studio/piggy60] move AVR PCB under rev1 #20253

merged 2 commits into from
Mar 29, 2023

Conversation

lesshonor
Copy link
Contributor

@lesshonor lesshonor commented Mar 24, 2023 •
edited
Loading

Description

As noted in #20232, this keyboard now has a new APM32/uf2boot-based PCB revision.
Move the old revision under rev1. Rev2 submission to follow.

(I also removed the old keyboard-level tapping_term defs, having learned that isn't kosher.)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team March 29, 2023 20:11
@waffle87 waffle87 merged commit 68a27b8 into qmk:develop Mar 29, 2023
@lesshonor lesshonor deleted the piggy60_rev1_move branch March 29, 2023 20:20
@lesshonor lesshonor mentioned this pull request Mar 30, 2023
Merged
14 tasks
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@lesshonor @coquizen
[jacky_studio/piggy60] move AVR PCB under rev1 (qmk#20253)
2d9655f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesshonor @drashna @waffle87