Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the KJ-Modify RS40 PCB keyboard #20243

Merged
merged 4 commits into from
Apr 2, 2023
Merged

Add the KJ-Modify RS40 PCB keyboard #20243

merged 4 commits into from
Apr 2, 2023

Conversation

AuditeMarlow
Copy link
Contributor

Description

Add the KJ-Modify RS40 PCB keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@AuditeMarlow AuditeMarlow force-pushed the add-kj_modify-rs40-keyboard branch from d91278e to 3ca4ac2 Compare March 24, 2023 15:07
elpekenin
elpekenin suggested changes Mar 26, 2023
View reviewed changes
keyboards/kj_modify/rs40/info.json Outdated Show resolved Hide resolved
keyboards/kj_modify/rs40/info.json Outdated Show resolved Hide resolved
data/mappings/keyboard_aliases.hjson Outdated Show resolved Hide resolved
@drashna drashna merged commit 12ea0e6 into qmk:develop Apr 2, 2023
@AuditeMarlow AuditeMarlow deleted the add-kj_modify-rs40-keyboard branch April 5, 2023 06:54
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@AuditeMarlow @coquizen
[Keyboard] Add the KJ-Modify RS40 PCB (qmk#20243)
89bf793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpekenin elpekenin elpekenin requested changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AuditeMarlow @drashna @elpekenin @waffle87