Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mlego/m48 to data driven #20223

Closed
wants to merge 10 commits into from
Closed

update mlego/m48 to data driven #20223

wants to merge 10 commits into from

Conversation

alinelena
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 22, 2023
@alinelena alinelena force-pushed the mlego_m48 branch 3 times, most recently from 3f8ecc0 to 6117c87 Compare March 23, 2023 03:19
@drashna drashna requested a review from a team March 29, 2023 18:48
tzarc
tzarc requested changes Apr 3, 2023
View reviewed changes
keyboards/mlego/m48/config.h Outdated Show resolved Hide resolved
@alinelena alinelena requested a review from tzarc April 3, 2023 08:00
@alinelena alinelena changed the title update mlego/m60 to data driven update mlego/m48 to data driven Apr 3, 2023
@fauxpark
Copy link
Member

fauxpark commented Apr 3, 2023

As of #20323 data-driven keyboard refactors should target develop.

@alinelena alinelena changed the base branch from master to develop April 3, 2023 09:53
@alinelena
Copy link
Contributor Author

As of #20323 data-driven keyboard refactors should target develop.

done

@alinelena alinelena requested review from fauxpark and drashna April 3, 2023 19:27
@alinelena
Copy link
Contributor Author

I will reopen this when #20224 is merged

@alinelena alinelena closed this May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc Awaiting requested review from tzarc

@fauxpark fauxpark Awaiting requested review from fauxpark

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alinelena @fauxpark @drashna @tzarc