Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RGB_DI_PIN ifdefs #20218

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Remove RGB_DI_PIN ifdefs #20218

merged 3 commits into from
Mar 23, 2023

Conversation

fauxpark
Copy link
Member

Description

For the most part, these don't serve any purpose as RGB_DI_PIN is usually defined immediately above. In some cases it is also used incorrectly to wrap RGBLight-related code.

This is a prerequisite for the eventual rename to WS2812_DI_PIN and move to info.json as ws2812.pin.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 22, 2023 05:05
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Mar 22, 2023
@fauxpark fauxpark merged commit ad625e7 into qmk:develop Mar 23, 2023
@fauxpark fauxpark deleted the remove-rgb-di-pin-ifdefs branch March 23, 2023 10:38
nicsuzor pushed a commit to nicsuzor/qmk_firmware that referenced this pull request Mar 28, 2023
@fauxpark @nicsuzor
Remove RGB_DI_PIN ifdefs (qmk#20218)
d872609
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@fauxpark @coquizen
Remove RGB_DI_PIN ifdefs (qmk#20218)
6c11c4a
@jpskenn jpskenn mentioned this pull request Nov 2, 2023
Open
39 tasks
jpskenn added a commit to jpskenn/qmk_firmware that referenced this pull request Nov 3, 2023
@jpskenn
Remove RGB_DI_PIN ifdefs (qmk#20218)
ce85273
jpskenn added a commit to jpskenn/qmk_firmware that referenced this pull request Nov 4, 2023
@jpskenn
Migrate rgblight.pin and RGB_DI_PIN to ws2812.pin (qmk#20303)
d2a20e1 
Remove RGB_DI_PIN ifdefs (qmk#20218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @tzarc