Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up usage of QMK_KEYBOARD_H #20167

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Clean up usage of QMK_KEYBOARD_H #20167

merged 1 commit into from
Mar 19, 2023

Conversation

fauxpark
Copy link
Member

Description

For keyboard-level code, better to reference headers that actually exist before compile time, to help with Intellisense etc.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 18, 2023 03:53
@drashna drashna requested a review from a team March 19, 2023 02:08
tzarc
tzarc approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHA1's all match.

@tzarc tzarc merged commit 3c144fa into qmk:develop Mar 19, 2023
@fauxpark fauxpark deleted the keyboard-h-macro-cleanup branch March 20, 2023 00:33
nicsuzor pushed a commit to nicsuzor/qmk_firmware that referenced this pull request Mar 28, 2023
@fauxpark @nicsuzor
Clean up usage of QMK_KEYBOARD_H (qmk#20167)
89897d8
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@fauxpark @coquizen
Clean up usage of QMK_KEYBOARD_H (qmk#20167)
873a375
LyricPants66133 added a commit to LyricPants66133/qmk_firmware that referenced this pull request Jul 10, 2023
@LyricPants66133
re-add accidental removal of quantum.h
3dfd0af 
quantum.h was removed and not properly added back by qmk#20167. This lead to some keymaps being uncompilable. This commit fixes that issue.
@LyricPants66133 LyricPants66133 mentioned this pull request Jul 10, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @tzarc