Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bootloader logic from mcu_selection.mk #20150

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Remove bootloader logic from mcu_selection.mk #20150

merged 2 commits into from
Mar 18, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 16, 2023 •
edited
Loading

Description

ld filename is now inferred from bootloader type. The find logic now checks for bootloader specific ld before falling back.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

sigprof
sigprof requested changes Mar 18, 2023
View reviewed changes
keyboards/phage_studio/pila87/rules.mk Outdated Show resolved Hide resolved
keyboards/rocketboard_16/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr force-pushed the tidy_bootloader_ld branch from 8115556 to f519d95 Compare March 18, 2023 16:14
@zvecr zvecr merged commit 50cb8a3 into qmk:develop Mar 18, 2023
nicsuzor pushed a commit to nicsuzor/qmk_firmware that referenced this pull request Mar 28, 2023
@zvecr @nicsuzor
Remove bootloader logic from mcu_selection.mk (qmk#20150)
55161a3 
* Remove bootloader logic from mcu_selection.mk

* Move MCU/BOOTLOADER to info.json
@lesshonor lesshonor mentioned this pull request Apr 27, 2023
Merged
14 tasks
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@zvecr @coquizen
Remove bootloader logic from mcu_selection.mk (qmk#20150)
8b1cd3c 
* Remove bootloader logic from mcu_selection.mk

* Move MCU/BOOTLOADER to info.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@sigprof sigprof sigprof approved these changes

Assignees
No one assigned
Labels
core keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @sigprof @fauxpark