Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust offset for some layouts #20075

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Mar 9, 2023

Description

Fixing layouts flagged by #20070, except for these three:

⚠ botanicalkeyboards/fm2u: Layout "LAYOUT_isoenter" is offset on X axis by 0.25
⚠ illuminati/is0: Layout "LAYOUT" is offset on X axis by 0.25
⚠ kb_elmo/isolation: Layout "LAYOUT" is offset on X axis by 0.25

as they are all just a single ISO enter. Might need special handling?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 9, 2023 20:26
@fauxpark fauxpark merged commit 9e2ef50 into qmk:develop Mar 13, 2023
@fauxpark fauxpark deleted the fix-offset-layouts branch March 13, 2023 11:22
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants