Change aidansmithdotdev/fine40 to use Encoder Map #19912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0dd205e.
…lt firmware, the PCB for the Mochi40
This directory was not meant to exist and will cause problems with merging
github-actions
bot
added
keyboard
keymap
via
zvecr
requested changes
Feb 22, 2023
Re-added functionality for configurator Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
|
Fixes have been applied and changes have been tested successfully on hardware. |
waffle87
reviewed
Feb 22, 2023
Co-authored-by: jack <[email protected]>
Swapping the behavior of the encoder was not working when done in the keymap.
Encoder direction was changed by a different pull request earlier. This has been remedied now in the correct spot
drashna
approved these changes
Mar 7, 2023
waffle87
approved these changes
Mar 7, 2023
coquizen
pushed a commit
to coquizen/qmk_firmware
that referenced
this pull request
Jun 22, 2023
Co-authored-by: Joel Challis <[email protected]> Co-authored-by: jack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code for all instances of the fine40 layout have been modified to use an encoder map. This was done to allow for users to define encoder rotation using VIA.
Types of Changes
Issues Fixed or Closed by This PR
Checklist