Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder keycodes with prior references to KC_MISSION_CONTROL/KC_LAUNCHPAD to cater for VIA definitions. #19905

Closed
wants to merge 3 commits into from
Closed

Reorder keycodes with prior references to KC_MISSION_CONTROL/KC_LAUNCHPAD to cater for VIA definitions. #19905

wants to merge 3 commits into from

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Feb 21, 2023

Description

See #19884.

Existing keycodes will revert to previous functionality, VIA will need to cater for 0.2.0 keycodes to pick up Mission Control and Launchpad.

Marked as tech debt in the code so that we're aware that we're waiting on a VIA update.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team February 21, 2023 21:00
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 21, 2023
@tzarc
Copy link
Member Author

tzarc commented Feb 21, 2023

Kept in draft as #19697 moves keycodes around for VIA as well.

@tzarc tzarc force-pushed the mission-control-launchpad_techdebt branch from aff35ac to 23936ff Compare February 22, 2023 20:42
@github-actions github-actions bot added the core label Feb 22, 2023
@tzarc tzarc force-pushed the mission-control-launchpad_techdebt branch from 23936ff to 346a26d Compare February 22, 2023 20:43
@tzarc tzarc force-pushed the mission-control-launchpad_techdebt branch from 346a26d to deed134 Compare February 22, 2023 20:43
@tzarc tzarc closed this Feb 22, 2023
@tzarc tzarc deleted the mission-control-launchpad_techdebt branch February 22, 2023 20:48
@tzarc
Copy link
Member Author

tzarc commented Feb 22, 2023

Factored into via_staging.

@tzarc tzarc mentioned this pull request Feb 22, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @wilba @zvecr