Sejin EAT-1010M2 keyboard #19802
Closed
Sejin EAT-1010M2 keyboard #19802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waffle87
requested changes
Feb 10, 2023
Comment on lines
+49
to
+58
|
|
||
| /* | ||
| void matrix_init_user(void) { | ||
| } | ||
| void matrix_scan_user(void) { | ||
| } | ||
| bool led_update_user(led_t led_state) { | ||
| return true; | ||
| } | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /* | |
| void matrix_init_user(void) { | |
| } | |
| void matrix_scan_user(void) { | |
| } | |
| bool led_update_user(led_t led_state) { | |
| return true; | |
| } | |
| */ |
| @@ -0,0 +1,62 @@ | |||
| # QMK-based firmware for Zenith Z-150 keyboard | |||
|
|
|||
|  | |||
There was a problem hiding this comment.
Suggested change
|  | |
|  |
|
|
||
| Make example for this keyboard (after setting up your build environment): | ||
|
|
||
| make handwired/z150:default |
There was a problem hiding this comment.
Suggested change
| make handwired/z150:default | |
| make handwired/sejin_eat1010r2:default | |
| Flashing example for this keyboard: | |
| make handwired/sejin_eat1010r2:default:flash | |
| make handwired/z150:default | ||
|
|
||
| See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs). | ||
|
|
There was a problem hiding this comment.
Please add instruction on entering bootloader mode, as per template.
| You can keep the original resistors, but with Black Pill or any other 3.3V controller the LEDs may seem a little dim. Try 150Ω or close value if you want to fix that. | ||
|
|
||
|
|
||
| ## Black Pill |
There was a problem hiding this comment.
info.json says this uses a bluepill? May want to clear that up.
| "backlight": false, | ||
| "sleep_led": false | ||
| }, | ||
| "debounce": 5 |
There was a problem hiding this comment.
Suggested change
| "debounce": 5 |
| "sleep_led": false | ||
| }, | ||
| "debounce": 5 | ||
| } |
There was a problem hiding this comment.
This file is missing the x, y coordinates (at the minimum). See configuator support.
Comment on lines
+20
to
+31
| #include "config_common.h" | ||
|
|
||
| /* key matrix size */ | ||
| #define MATRIX_ROWS 8 | ||
| #define MATRIX_COLS 16 | ||
|
|
||
| #define MATRIX_HAS_GHOST | ||
|
|
||
| #define NUM_LOCK_LED_PIN B0 | ||
| #define SCROLL_LOCK_LED_PIN B10 | ||
| #define CAPS_LOCK_LED_PIN B1 | ||
|
|
There was a problem hiding this comment.
Suggested change
| #include "config_common.h" | |
| /* key matrix size */ | |
| #define MATRIX_ROWS 8 | |
| #define MATRIX_COLS 16 | |
| #define MATRIX_HAS_GHOST | |
| #define NUM_LOCK_LED_PIN B0 | |
| #define SCROLL_LOCK_LED_PIN B10 | |
| #define CAPS_LOCK_LED_PIN B1 | |
| #define MATRIX_HAS_GHOST |
Comment on lines
+20
to
+31
| "command": false, | ||
| "console": false, | ||
| "extrakey": true, | ||
| "midi": false, | ||
| "mousekey": true, | ||
| "nkro": false, | ||
| "rgblight": false, | ||
| "unicode": false, | ||
| "bluetooth": false, | ||
| "backlight": false, | ||
| "sleep_led": false | ||
| }, |
There was a problem hiding this comment.
Suggested change
| "command": false, | |
| "console": false, | |
| "extrakey": true, | |
| "midi": false, | |
| "mousekey": true, | |
| "nkro": false, | |
| "rgblight": false, | |
| "unicode": false, | |
| "bluetooth": false, | |
| "backlight": false, | |
| "sleep_led": false | |
| }, | |
| "command": false, | |
| "console": false, | |
| "extrakey": true, | |
| "midi": false, | |
| "mousekey": true, | |
| "nkro": false, | |
| "rgblight": false, | |
| "unicode": false, | |
| "bluetooth": false, | |
| "backlight": false, | |
| "sleep_led": false | |
| }, | |
| "indicators": { | |
| "num_lock": "B0", | |
| "caps_lock": "B1", | |
| "scroll_lock": "B10", | |
| }, |
Comment on lines
+18
to
+39
|
|
||
| void matrix_init_kb(void) { | ||
| setPinOutput(NUM_LOCK_LED_PIN); | ||
| setPinOutput(CAPS_LOCK_LED_PIN); | ||
| setPinOutput(SCROLL_LOCK_LED_PIN); | ||
|
|
||
| writePinLow(NUM_LOCK_LED_PIN); | ||
| writePinLow(CAPS_LOCK_LED_PIN); | ||
| writePinLow(SCROLL_LOCK_LED_PIN); | ||
|
|
||
| matrix_init_user(); | ||
| } | ||
|
|
||
| bool led_update_kb(led_t led_state) { | ||
| bool res = led_update_user(led_state); | ||
| if(res) { | ||
| writePin(NUM_LOCK_LED_PIN, !led_state.num_lock); | ||
| writePin(CAPS_LOCK_LED_PIN, !led_state.caps_lock); | ||
| writePin(SCROLL_LOCK_LED_PIN, !led_state.scroll_lock); | ||
| } | ||
| return res; | ||
| } |
There was a problem hiding this comment.
Suggested change
| void matrix_init_kb(void) { | |
| setPinOutput(NUM_LOCK_LED_PIN); | |
| setPinOutput(CAPS_LOCK_LED_PIN); | |
| setPinOutput(SCROLL_LOCK_LED_PIN); | |
| writePinLow(NUM_LOCK_LED_PIN); | |
| writePinLow(CAPS_LOCK_LED_PIN); | |
| writePinLow(SCROLL_LOCK_LED_PIN); | |
| matrix_init_user(); | |
| } | |
| bool led_update_kb(led_t led_state) { | |
| bool res = led_update_user(led_state); | |
| if(res) { | |
| writePin(NUM_LOCK_LED_PIN, !led_state.num_lock); | |
| writePin(CAPS_LOCK_LED_PIN, !led_state.caps_lock); | |
| writePin(SCROLL_LOCK_LED_PIN, !led_state.scroll_lock); | |
| } | |
| return res; | |
| } |
|
Sorry, I messed up something in my fork. I'd better delete this pull request and fix everything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sejin Electronics EAT-1010M2 controller replacement.
Handwired Blue Pill to membrane.
Types of Changes
Checklist