Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add Repeat Key ("repeat last key") as a core feature. #19700

Merged
merged 47 commits into from
May 20, 2023
Merged
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
72ebb0e
Add Repeat Key as a core QMK feature.
getreuer Jan 21, 2023
e7027bf
Add Repeat Key + Combo test and minor formatting.
getreuer Jan 21, 2023
4beacae
Add .hjson defs for QK_REPEAT_KEY.
getreuer Jan 21, 2023
0558fe1
Fix Repeat Key behavior on rolled presses.
getreuer Jan 21, 2023
f9c6fcd
Add Reverse Repeat Key.
getreuer Jan 25, 2023
bc6c00e
Minor edits and elaborations.
getreuer Jan 25, 2023
3c3c5a9
Merge branch 'develop' into core/repeat_key
getreuer Jan 25, 2023
e31690f
A few doc tweaks.
getreuer Jan 26, 2023
d43defc
Use IS_SWAP_HANDS_KEYCODE.
getreuer Jan 27, 2023
ea04ff4
Fix a couple indents.
getreuer Jan 28, 2023
3e01585
Fix code formatting.
getreuer Jan 28, 2023
5ed45d0
Minor doc tweak.
getreuer Jan 28, 2023
a93a533
Remove accidental self-referential #include.
getreuer Feb 3, 2023
b593e90
Run `qmk generate-keycodes-tests -v latest`
getreuer Feb 11, 2023
2814d13
Run `util/regen.sh` to try to pass check
getreuer Feb 11, 2023
2e254f3
Merge branch 'develop' into core/repeat_key
getreuer Feb 13, 2023
bd4c09a
Rename Reverse Repeat -> Alternate Repeat.
getreuer Feb 20, 2023
d9bd088
Merge branch 'develop' into core/repeat_key
getreuer Feb 24, 2023
3c52ad3
Merge branch 'develop' into core/repeat_key
getreuer Feb 28, 2023
d948882
Update for QMK 0.20, bump to keycodes_0.0.3.
getreuer Feb 28, 2023
5a66c54
Merge branch 'develop' into core/repeat_key
getreuer Mar 4, 2023
f558b99
Add Repeat Key to keyboard.jsonschema.
getreuer Mar 5, 2023
49bb750
Remove trailing comma.
getreuer Mar 5, 2023
3c4643d
Remove trailing comma.
getreuer Mar 5, 2023
69babda
Minor doc edits.
getreuer Mar 6, 2023
c40b31e
Merge branch 'develop' into core/repeat_key
getreuer Mar 17, 2023
bd082df
Merge branch 'develop' into core/repeat_key
getreuer Mar 25, 2023
ab21d08
Add Tri Layer keys to default get_repeat_key_eligible().
getreuer Mar 30, 2023
d5b4970
Revise with a "get_repeat_key_eligible_user()".
getreuer Mar 30, 2023
30d0cbe
Format code.
getreuer Mar 30, 2023
15d1d50
Add more Alt Repeat examples to the docs.
getreuer Mar 30, 2023
620b047
Update data/constants/keycodes/keycodes_0.0.2_quantum.hjson
getreuer Mar 31, 2023
a0c5461
Update quantum/repeat_key.c
getreuer Mar 31, 2023
5d74f09
Update quantum/repeat_key.c
getreuer Mar 31, 2023
20bfde4
Alt repeat: use KC_TRNS to defer to defaults.
getreuer Mar 31, 2023
86ac71f
`remembered_mods` arg to enable fitering the mods.
getreuer Mar 31, 2023
ac83f21
Merge branch 'develop' into core/repeat_key
getreuer Apr 7, 2023
8ad9259
Fix test, set event.type.
getreuer Apr 8, 2023
6cb20d4
Add default alt keys for Vim jumplist.
getreuer Apr 14, 2023
85947f5
Merge branch 'develop' into core/repeat_key
getreuer Apr 21, 2023
96c6eb4
Merge branch 'develop' into core/repeat_key
getreuer May 7, 2023
3353606
Documentation fix, updated fun signature.
getreuer May 7, 2023
5525497
Add test of additional alt keys example.
getreuer May 7, 2023
12d58e8
Merge branch 'develop' into core/repeat_key
getreuer May 12, 2023
f4fc703
Make last key logic more separate from repeating.
getreuer May 14, 2023
1f8e074
Merge branch 'develop' into core/repeat_key
getreuer May 14, 2023
c90b285
Fix code formatting.
getreuer May 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions builddefs/generic_features.mk
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ GENERIC_FEATURES = \
KEY_OVERRIDE \
LEADER \
PROGRAMMABLE_BUTTON \
REPEAT_KEY \
SECURE \
SPACE_CADET \
SWAP_HANDS \
Expand Down
3 changes: 2 additions & 1 deletion builddefs/show_options.mk
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ OTHER_OPTION_NAMES = \
SECURE_ENABLE \
CAPS_WORD_ENABLE \
AUTOCORRECT_ENABLE \
TRI_LAYER_ENABLE
TRI_LAYER_ENABLE \
REPEAT_KEY_ENABLE

define NAME_ECHO
@printf " %-30s = %-16s # %s\\n" "$1" "$($1)" "$(origin $1)"
Expand Down
2 changes: 1 addition & 1 deletion data/constants/keycodes/keycodes_0.0.2_quantum.hjson
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
"aliases": [
"TL_UPPR"
]
}
},
getreuer marked this conversation as resolved.
Show resolved Hide resolved
}
}
Empty file.
18 changes: 18 additions & 0 deletions data/constants/keycodes/keycodes_0.0.3_quantum.hjson
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"keycodes": {
"0x7C79": {
"group": "quantum",
"key": "QK_REPEAT_KEY",
"aliases": [
"QK_REP"
]
},
"0x7C7A": {
"group": "quantum",
"key": "QK_ALT_REPEAT_KEY",
"aliases": [
"QK_AREP"
]
}
}
}
1 change: 1 addition & 0 deletions data/mappings/info_rules.hjson
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"MOUSEKEY_ENABLE": {"info_key": "mouse_key.enabled", "value_type": "bool"},
"NO_USB_STARTUP_CHECK": {"info_key": "usb.no_startup_check", "value_type": "bool"},
"PIN_COMPATIBLE": {"info_key": "pin_compatible"},
"REPEAT_KEY_ENABLE": {"info_key": "repeat_key.enabled", "value_type": "bool"},
"SECURE_ENABLE": {"info_key": "secure.enabled", "value_type": "bool"},
"SPLIT_KEYBOARD": {"info_key": "split.enabled", "value_type": "bool"},
"SPLIT_TRANSPORT": {"info_key": "split.transport.protocol", "to_c": false},
Expand Down
7 changes: 7 additions & 0 deletions data/schemas/keyboard.jsonschema
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,13 @@
}
}
},
"repeat_key": {
"type": "object",
"additionalProperties": false,
"properties": {
"enabled": {"type": "boolean"}
}
},
getreuer marked this conversation as resolved.
Show resolved Hide resolved
"rgb_matrix": {
"type": "object",
"properties": {
Expand Down
1 change: 1 addition & 0 deletions docs/_summary.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
* [Macros](feature_macros.md)
* [Mouse Keys](feature_mouse_keys.md)
* [Programmable Button](feature_programmable_button.md)
* [Repeat Key](feature_repeat_key.md)
* [Space Cadet Shift](feature_space_cadet.md)
* [US ANSI Shifted Keys](keycodes_us_ansi_shifted.md)

Expand Down
Loading