Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Use correct functions for RGB Matrix support in VIA #19554

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

drashna
Copy link
Member

@drashna drashna commented Jan 10, 2023

Description

VIA uses RGBLIGHT functions in the RGB Matrix section. Normally, this is okay, but if you have both features enabled .... not so much. So, naturally, I run into this.

Types of Changes

  • Core
  • Bugfix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team January 10, 2023 03:09
@zvecr zvecr merged commit 90fd08b into qmk:master Jan 10, 2023
@drashna drashna deleted the fix_via_rgb_matrix branch January 10, 2023 04:33
sboysel pushed a commit to sboysel/qmk_firmware that referenced this pull request Jan 17, 2023
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants