Fixup horrortroll/handwired_k552 #19447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
approved these changes
Dec 31, 2022
|
Hi! I'm sorry, there a reason why this line on rules.mk was here. Because it was needed #18035, but the PR was not merged yet. So this ldscript was not found. But thanks, revert this ldscript back to the one in keyboard folder, it should be like that until that PR got merged |
drashna
approved these changes
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
STM32F103xC_stm32duino_bootloader.lddoesn't exist. I presume the linker script in the keyboard directory is what's meant to be used.cc @HorrorTroll
Types of Changes
Checklist