A fancy keymap for the wt65_xt. #19375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Extract a lot of this logic and make it more widely usable for polyglot keyboards!
drashna
reviewed
Dec 23, 2022
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| #pragma once |
There was a problem hiding this comment.
If there is nothing here, then this file can (and should) be removed.
| */ | ||
| #include QMK_KEYBOARD_H | ||
| #include <assert.h> | ||
| #include "wt65_xt.h" |
There was a problem hiding this comment.
Isn't needed. QMK_KEYBOARD_H is generated as this, already.
Suggested change
| #include "wt65_xt.h" |
| _MAC = 1, | ||
| _OS_MODES_MAX = 2, | ||
| }; | ||
| static int os_mode = _MAC; |
There was a problem hiding this comment.
May want to use an unsigned 8 bit int, as it may save a bit of space. (also better to be specific)
Suggested change
| static int os_mode = _MAC; | |
| static uint8_t os_mode = _MAC; |
There was a problem hiding this comment.
Good idea; done.
Also fix unicode mode selection, oops.
drashna
reviewed
Dec 27, 2022
| #define NON_LANGUAGE_LAYERS ~(((1UL << _LAST_LANGUAGE_LAYER) - 1) - ((1UL << _FIRST_LANGUAGE_LAYER) - 1)) | ||
|
|
||
| // Update the current layer state and return the layer we're in. | ||
| int update_layer( |
There was a problem hiding this comment.
Probably worth converting these to uint8_t from int.
There was a problem hiding this comment.
Good call, done.
drashna
approved these changes
Dec 27, 2022
tzarc
approved these changes
Dec 30, 2022
sbhal
pushed a commit
to sbhal/qmk_firmware
that referenced
this pull request
Dec 30, 2022
jasonisgraham
pushed a commit
to jasonisgraham/qmk_firmware
that referenced
this pull request
Jan 2, 2023
omikronik
pushed a commit
to omikronik/qmk_firmware
that referenced
this pull request
Jan 22, 2023
ideas32
pushed a commit
to ideas32/qmk_firmware
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Extract a lot of this logic and make it more widely usable for polyglot keyboards!
Description
Adding a custom keymap. Testing out several ideas to generalize later!
Types of Changes
Issues Fixed or Closed by This PR
Checklist