Custom keyboard layout

[snowskeleton]

first commit of my Preonic layout
Type:

• Keymap/layout/userspace (addition or update)

Checklist:

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[drashna]

Also, since it appears that you're not using it, you may want to remove the muse mode code.

[snowskeleton]

alright, I think I like where it's at now. thank you so much for your feedback! Everything is much cleaner now with it implemented :)

is there anything else I should change?

[trguhq]

alright, I think I like where it's at now. thank you so much for your feedback! Everything is much cleaner now with it implemented :)

is there anything else I should change?

It's not compiling right now, check the red X. I am not a reviewer, just trying to be helpful. To me if it doesn't work with every target for its folder it'd be nice if the documentation was explicit about that but I don't know about expectations in that regard. Perhaps "with rotary encoder" is explicit enough here?

Maybe just as easy as:

#if !defined(KEYBOARD_preonic_rev1) && !defined(KEYBOARD_preonic_rev2)
#define ENCODERS_PAD_A { B12 }
#define ENCODERS_PAD_B { B13 }
#endif

Or maybe you could check against __AVR__ as you do elsewhere in the code and not enable any of the rotary encoder stuff if that's defined.

Or if you don't want it to compile for those keyboards and you don't want to support them, maybe something like:

#ifdef __AVR__
#pragma message("This keymap only supports preonic rev3 and later keyboards with an ARM microcontroller!")
#endif 

Or:

#ifdef __AVR__
#error "This keymap only supports preonic rev3 and later keyboards with an ARM microcontroller!"
#endif 

Or maybe:

#ifndef __arm__

Or maybe something can be done in rules.mk.

Or maybe it doesn't matter... Just an idea. Those boards have a different MCU which doesn't have those pins...

[drashna]

This may help with the compiler errors for the other revisions, but isn't strictly required.

[drashna]

Suggested change

ENCODER_ENABLE = yes