Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keychron Q60 #19309

Merged
merged 7 commits into from
Dec 19, 2022
Merged

Add Keychron Q60 #19309

merged 7 commits into from
Dec 19, 2022

Conversation

KeychronMacro
Copy link
Contributor

We added new keyboard Q60.
Thanks!

Description

We added ANSI versions.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Dec 13, 2022
View reviewed changes
keyboards/keychron/q60/ansi/ansi.h Outdated Show resolved Hide resolved
keyboards/keychron/q60/ansi/ansi.c Outdated Show resolved Hide resolved
keyboards/keychron/q60/ansi/config.h Outdated Show resolved Hide resolved
keyboards/keychron/q60/ansi/readme.md Outdated Show resolved Hide resolved
keyboards/keychron/q60/config.h Outdated Show resolved Hide resolved
keyboards/keychron/q60/q60.c Outdated Show resolved Hide resolved
keyboards/keychron/q60/q60.h Outdated Show resolved Hide resolved
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 14, 2022
@keychron-dev
Copy link

@waffle87 please have a look at this too

@drashna drashna requested review from a team and removed request for waffle87 December 18, 2022 03:28
@tzarc tzarc merged commit 90c4a87 into qmk:master Dec 19, 2022
@KeychronMacro KeychronMacro mentioned this pull request Dec 20, 2022
Merged
6 tasks
@KeychronMacro KeychronMacro deleted the keychron-q60 branch December 27, 2022 01:20
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@KeychronMacro @waffle87
Add Keychron Q60 (qmk#19309)
2974460 
Co-authored-by: jack <[email protected]>
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@KeychronMacro @waffle87 @omikronik
Add Keychron Q60 (qmk#19309)
90721a7 
Co-authored-by: jack <[email protected]>
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@KeychronMacro @waffle87 @ideas32
Add Keychron Q60 (qmk#19309)
79692d2 
Co-authored-by: jack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 requested changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KeychronMacro @keychron-dev @drashna @tzarc @waffle87 @galican