-
-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging keymaps for user profile PeterFalken. #19299
Conversation
chore: change RESET to QK_BOOT chore: reduce USB power consumption
I hope there was a way to disable/undefine all RGB_MATRIX effects similar to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the folders to be all lower case.
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
@fauxpark, I think the changes you requested should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to consider using the userspace feature, since you have a lot of repeated code, here.
// } | ||
|
||
|
||
void matrix_scan_user(void) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
void matrix_scan_user(void) { | |
void housekeeping_task_user(void) { |
Replaced by PR-19897 |
Description
Merging keymaps for PeterFalken.
Key boards:
Adafruit: Macropad
OLKB: Planck/rev6_drop & Preonic/rev3_drop
System76: Launch_1
Work Louder: loop, micro, nano & work_board
Types of Changes
Issues Fixed or Closed by This PR
Checklist