Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging keymaps for user profile PeterFalken. #19299

Closed
wants to merge 44 commits into from

Conversation

PeterFalken
Copy link
Contributor

@PeterFalken PeterFalken commented Dec 11, 2022

Description

Merging keymaps for PeterFalken.
Key boards:
Adafruit: Macropad
OLKB: Planck/rev6_drop & Preonic/rev3_drop
System76: Launch_1
Work Louder: loop, micro, nano & work_board

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@PeterFalken PeterFalken changed the title My.keebs Merging keymaps for user profile PeterFalken. Dec 11, 2022
keyboards/adafruit/macropad/keymaps/PeterFalken/config.h Outdated Show resolved Hide resolved
keyboards/adafruit/macropad/keymaps/PeterFalken/config.h Outdated Show resolved Hide resolved
keyboards/adafruit/macropad/keymaps/PeterFalken/rules.mk Outdated Show resolved Hide resolved
keyboards/planck/keymaps/PeterFalken/config.h Outdated Show resolved Hide resolved
keyboards/planck/keymaps/PeterFalken/readme.md Outdated Show resolved Hide resolved
keyboards/work_louder/nano/keymaps/PeterFalken/rules.mk Outdated Show resolved Hide resolved
@PeterFalken
Copy link
Contributor Author

I hope there was a way to disable/undefine all RGB_MATRIX effects similar to
#undef RGBLIGHT_ANIMATIONS

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the folders to be all lower case.

keyboards/work_louder/micro/keymaps/PeterFalken/config.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team December 13, 2022 02:50
keyboards/preonic/keymaps/peterfalken/config.h Outdated Show resolved Hide resolved
keyboards/planck/keymaps/peterfalken/config.h Outdated Show resolved Hide resolved
@PeterFalken
Copy link
Contributor Author

@fauxpark, I think the changes you requested should be good now.

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to consider using the userspace feature, since you have a lot of repeated code, here.

https://docs.qmk.fm/#/feature_userspace

// }


void matrix_scan_user(void) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
void matrix_scan_user(void) {
void housekeeping_task_user(void) {

@PeterFalken
Copy link
Contributor Author

Replaced by PR-19897

@PeterFalken PeterFalken deleted the my.keebs branch March 12, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants