Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ydpm40 keyboard #19294

Merged
merged 1 commit into from
Dec 12, 2022
Merged

add ydpm40 keyboard #19294

merged 1 commit into from
Dec 12, 2022

Conversation

xofyarg
Copy link
Contributor

@xofyarg xofyarg commented Dec 11, 2022

This PR adds support for a atmega328p keyboard, whose original firmware was tmk.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Dec 12, 2022
View reviewed changes
keyboards/ydkb/ydpm40/keymaps/default Outdated Show resolved Hide resolved
keyboards/ydkb/ydpm40/info.json Outdated Show resolved Hide resolved
@xofyarg
Copy link
Contributor Author

xofyarg commented Dec 12, 2022

Updated, please take another look.

@drashna drashna requested a review from a team December 12, 2022 05:18
fauxpark
fauxpark requested changes Dec 12, 2022
View reviewed changes
keyboards/ydkb/ydpm40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ydkb/ydpm40/readme.md Outdated Show resolved Hide resolved
keyboards/ydkb/ydpm40/readme.md Outdated Show resolved Hide resolved
keyboards/ydkb/ydpm40/readme.md Outdated Show resolved Hide resolved
keyboards/ydkb/ydpm40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ydkb/ydpm40/keymaps/ydm40/keymap.c Outdated Show resolved Hide resolved
keyboards/ydkb/ydpm40/keymaps/ydm40/keymap.c Outdated Show resolved Hide resolved
@xofyarg
add ydpm40 keyboard
b2e627a 
This PR adds support for a atmega328p keyboard, whose original
firmware was tmk.
@xofyarg
Copy link
Contributor Author

xofyarg commented Dec 12, 2022

Thank you @fauxpark for the help to make this happen. All the issues you pointed out should be fixed now.

@drashna drashna merged commit 25790fc into qmk:master Dec 12, 2022
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@xofyarg @crembz
[Keyboard] add ydpm40 keyboard (qmk#19294)
65a2a05
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@xofyarg
[Keyboard] add ydpm40 keyboard (qmk#19294)
a68fbdd
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@xofyarg @omikronik
[Keyboard] add ydpm40 keyboard (qmk#19294)
f1a9a0f
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@xofyarg @ideas32
[Keyboard] add ydpm40 keyboard (qmk#19294)
168ae6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xofyarg @drashna @fauxpark @zvecr