Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up Info.Json files that weren't parsing correctly #19275

Merged
merged 6 commits into from
Dec 9, 2022

Conversation

ToastyStoemp
Copy link
Contributor

@ToastyStoemp ToastyStoemp commented Dec 9, 2022

Description

There were a few boards that still had comments, missing comma's or extra comma's that wouldn't parse.
This fixes those boards

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ToastyStoemp ToastyStoemp changed the title Make Jscotto boards compatible with JSON parser Fix up Info.Json files that weren't parsing correctly Dec 9, 2022
@zvecr
Copy link
Member

zvecr commented Dec 9, 2022

info.json is still hjson at the moment, however the .json extension is maintained for the amount of impact renaming would currently have. We currently have not made a decision on if we will downgrade to json any time soon.

Apart from keyboards/kbdfans/kbdpad/mk3/info.json, the files were missed on purpose in the previous refactoring pass.

@fauxpark
Copy link
Member

fauxpark commented Dec 9, 2022

Comments are allowed in info.json; they are actually meant to be HJSON. The QMK API serves these as proper JSON: https://keyboards.qmk.fm/v1/keyboards/handwired/jscotto/scotto36/info.json

@ToastyStoemp
Copy link
Contributor Author

I scanned through all current boards in develop, these were the only boards that didn't parse. Hence I was convinced it was pretty much supposed to be json, I can revert the comment changes and just keep the small comma fixes

@zvecr zvecr merged commit aa06a6e into qmk:develop Dec 9, 2022
@ToastyStoemp ToastyStoemp deleted the json-parser-compatible branch December 9, 2022 04:31
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants