Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated led_set_kb #19273

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Remove deprecated led_set_kb #19273

merged 2 commits into from
Dec 14, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 9, 2022 •
edited
Loading

Description

Remove led_set_kb maintaining existing led_set_user behaviour.
Future passes will start to refactor led_set_user to led_update_user.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team December 9, 2022 02:48
@zvecr zvecr changed the title Remove led_set_kb maintaining existing led_set_user behaviour Remove deprecated led_set_kb Dec 9, 2022
@drashna drashna requested a review from a team December 10, 2022 19:29
@zvecr zvecr merged commit 1124bbc into qmk:develop Dec 14, 2022
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
Remove deprecated led_set_kb (qmk#19273)
aa33d4e 
* Remove led_set_kb maintaining existing led_set_user behaviour

* Also call led_set_user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation keyboard keymap translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @drashna @tzarc @fauxpark