Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keymap] Keeb.io Sinc - Lickel keymap update #19188

Merged
merged 3 commits into from
Dec 10, 2022
Merged

[Keymap] Keeb.io Sinc - Lickel keymap update #19188

merged 3 commits into from
Dec 10, 2022

Conversation

lickel
Copy link
Contributor

@lickel lickel commented Nov 28, 2022

This updates my existing keymap to be enable ENCODER_MAP_ENABLE

Description

This makes it consistent with the via keymap

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@lickel lickel marked this pull request as draft November 28, 2022 23:08
@drashna drashna requested a review from a team December 4, 2022 02:34
@drashna drashna requested a review from a team December 4, 2022 02:35
@lickel lickel marked this pull request as ready for review December 10, 2022 05:27
@lickel
Copy link
Contributor Author

lickel commented Dec 10, 2022

Sorry for having thrown this into draft for a bit after opening a PR. I was having difficulty testing things (since resolved).

@drashna drashna merged commit 143b7a3 into qmk:master Dec 10, 2022
@drashna
Copy link
Member

drashna commented Dec 10, 2022

No worries!

crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@lickel @crembz
[Keymap] Keeb.io Sinc - Lickel keymap update (qmk#19188)
6dd6cd2
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@lickel
[Keymap] Keeb.io Sinc - Lickel keymap update (qmk#19188)
2f59f3c
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@lickel @omikronik
[Keymap] Keeb.io Sinc - Lickel keymap update (qmk#19188)
bd4e2de
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@lickel @ideas32
[Keymap] Keeb.io Sinc - Lickel keymap update (qmk#19188)
d196054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lickel @drashna @fauxpark